[vlc-commits] [Git][videolan/vlc][master] 2 commits: contrib: speexdsp: fix NEON support on Linux

[Rémi Denis-Courmont (@Courmisch)]

Rémi Denis-Courmont pushed to branch master at VideoLAN / VLC


Commits:
e26e077b by Rémi Denis-Courmont at 2022-10-07T17:16:15+03:00
contrib: speexdsp: fix NEON support on Linux

The HAVE_NEON flag is only ever defined on select platforms. That is to
say first Android which had one build with and one without it. Later on,
it was also added to iOS.

It cannot be assumed that NEON is not there just because the flag is
unspecified. This silently broke NEON support on Linux, and literally
any other platform at the time this regression was introduced.

Strictly speaking, we could keep checking the flag on Android or iOS on
ARM or AArch64. But as of now, all four of those platforms always set
HAVE_NEON, so this would not have any effect. We still forcefully
disable NEON on Android-x86, which was the original purpose of this
stanza.

Regression from ef98e81ff014175fd7494c8313de8883d15834b3.

- - - - -
d5ad888a by Rémi Denis-Courmont at 2022-10-07T17:16:15+03:00
contrib: speexdsp: do not disable NEON on AArch64

Support for AArch64 was added in speexdsp 1.2.0~rc5, except on
Windows for which we already have a patch.

- - - - -


1 changed file:

- contrib/src/speexdsp/rules.mak


Changes:

=====================================
contrib/src/speexdsp/rules.mak
=====================================
@@ -20,15 +20,11 @@ speexdsp: speexdsp-$(SPEEXDSP_VERSION).tar.gz .sum-speexdsp
 	$(MOVE)
 
 SPEEXDSP_CONF := --enable-resample-full-sinc-table --disable-examples
-ifeq ($(ARCH),aarch64)
-# old neon, not compatible with aarch64
+ifeq ($(filter arm aarch64, $(ARCH)),)
+# The configure script checks for NEON C intrinsics only.
+# This leads to false positives on Android-x86.
 SPEEXDSP_CONF += --disable-neon
 endif
-ifeq ($(ARCH),arm)
-ifndef HAVE_NEON
-SPEEXDSP_CONF += --disable-neon
-endif
-endif
 ifndef HAVE_FPU
 SPEEXDSP_CONF += --enable-fixed-point
 ifeq ($(ARCH),arm)



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/80489c822c7f6f973780bdc9b24e9137c8b6be1c...d5ad888a6b5c65731156fe82646e9d5a3af56aa8

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/80489c822c7f6f973780bdc9b24e9137c8b6be1c...d5ad888a6b5c65731156fe82646e9d5a3af56aa8
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance