[vlc-commits] [Git][videolan/vlc][master] qt: avoid both virtual and override on dtors

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
e68e8525 by Johannes Kauffmann at 2022-09-01T07:49:32+00:00
qt: avoid both virtual and override on dtors

When inheriting from classes with a virtual destructor, it is not needed
to declare the destructor both as virtual and override. In line with the
normal policy for virtual vs override, use virtual only when declaring
the base class destructor.

- - - - -


2 changed files:

- modules/gui/qt/network/networkmediamodel.hpp
- modules/gui/qt/network/servicesdiscoverymodel.hpp


Changes:

=====================================
modules/gui/qt/network/networkmediamodel.hpp
=====================================
@@ -147,7 +147,7 @@ public:
     Q_PROPERTY(int count READ getCount NOTIFY countChanged)
 
     explicit NetworkMediaModel(QObject* parent = nullptr);
-    virtual ~NetworkMediaModel() override;
+    ~NetworkMediaModel() override;
 
     QVariant data(const QModelIndex& index, int role) const override;
     QHash<int, QByteArray> roleNames() const override;


=====================================
modules/gui/qt/network/servicesdiscoverymodel.hpp
=====================================
@@ -67,7 +67,7 @@ public:
     Q_ENUM(Role);
 
     explicit ServicesDiscoveryModel(QObject* parent = nullptr);
-    virtual ~ServicesDiscoveryModel() override;
+    ~ServicesDiscoveryModel() override;
 
     QVariant data(const QModelIndex& index, int role) const override;
     QHash<int, QByteArray> roleNames() const override;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e68e852556bd7b455347988a03c337e18cddbdc8

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e68e852556bd7b455347988a03c337e18cddbdc8
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance