[vlc-commits] [Git][videolan/vlc][master] 3 commits: qt: mainctx: use make_unique

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
feb1912a by Johannes Kauffmann at 2022-09-09T11:53:21+00:00
qt: mainctx: use make_unique

- - - - -
e192c0ed by Johannes Kauffmann at 2022-09-09T11:53:21+00:00
qt: roundimage: avoid Q_SLOTS usage

- - - - -
67c6ec49 by Johannes Kauffmann at 2022-09-09T11:53:21+00:00
qt: custom_menus: fix spelling mistake

- - - - -


3 changed files:

- modules/gui/qt/maininterface/mainctx.cpp
- modules/gui/qt/menus/custom_menus.hpp
- modules/gui/qt/widgets/native/roundimage.hpp


Changes:

=====================================
modules/gui/qt/maininterface/mainctx.cpp
=====================================
@@ -548,7 +548,7 @@ void MainCtx::createSystray()
     sysTray = new QSystemTrayIcon( iconVLC, this );
     sysTray->setToolTip( qtr( "VLC media player" ));
 
-    systrayMenu.reset(new QMenu( qtr( "VLC media player") ));
+    systrayMenu = std::make_unique<QMenu>( qtr( "VLC media player") );
     systrayMenu->setIcon( iconVLC );
 
     VLCMenuBar::updateSystrayMenu( this, p_intf, true );


=====================================
modules/gui/qt/menus/custom_menus.hpp
=====================================
@@ -143,7 +143,7 @@ private:
 };
 
 /**
- * @brief The BooleanPropertyAction class allows to bind a boolean Q_PROPRERTY to a QAction
+ * @brief The BooleanPropertyAction class allows to bind a boolean Q_PROPERTY to a QAction
  */
 class BooleanPropertyAction: public QAction
 {


=====================================
modules/gui/qt/widgets/native/roundimage.hpp
=====================================
@@ -83,8 +83,11 @@ private:
     void setRoundImage(QImage image);
     void setStatus(const Status status);
     void regenerateRoundImage();
-    Q_SLOT void adjustQSGCustomGeometry(const QQuickWindow* const window);
 
+private slots:
+    void adjustQSGCustomGeometry(const QQuickWindow* const window);
+
+private:
     QUrl m_source;
     qreal m_radius = 0.0;
     qreal m_dpr = 1.0; // device pixel ratio



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/3de5b7f1ee932d2b61235ebe6490c31da7727548...67c6ec49aaca190942f460805915fcf81cddf131

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/3de5b7f1ee932d2b61235ebe6490c31da7727548...67c6ec49aaca190942f460805915fcf81cddf131
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance