[vlc-commits] [Git][videolan/vlc][master] qt: fix crash when cancelling round image generation

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
fe07979f by Pierre Lamot at 2022-09-27T19:03:20+00:00
qt: fix crash when cancelling round image generation

the cancel signal will call the handleImageResponseFinished callback which calls
resetImageResponse again, the nested call will set m_activeImageResponse to
null, then the first call will try to use disconnect on a null object.

- - - - -


1 changed file:

- modules/gui/qt/widgets/native/roundimage.cpp


Changes:

=====================================
modules/gui/qt/widgets/native/roundimage.cpp
=====================================
@@ -554,10 +554,11 @@ void RoundImage::resetImageResponse(bool cancel)
     if (!m_activeImageResponse)
         return;
 
+    m_activeImageResponse->disconnect(this);
+
     if (cancel)
         m_activeImageResponse->cancel();
 
-    m_activeImageResponse->disconnect(this);
     m_activeImageResponse = nullptr;
 }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/fe07979f55370b6296085a25083ed319130ca980

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/fe07979f55370b6296085a25083ed319130ca980
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance