[vlc-commits] [Git][videolan/vlc][master] qt: Fix the calling convention for DCompositionCreateDeviceFun

Jean-Baptiste Kempf (@jbk) gitlab at videolan.org
Thu Sep 29 07:11:50 UTC 2022



Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
2eeada26 by Martin Storsjö at 2022-09-29T06:55:01+00:00
qt: Fix the calling convention for DCompositionCreateDeviceFun

This fixes i686 builds with Clang. GCC builds seem to have dodged
the bullet here by using a frame pointer, while LLVM seems to omit
the frame pointer in the functions that call these function
pointers.

- - - - -


2 changed files:

- modules/gui/qt/maininterface/compositor_dcomp.cpp
- modules/gui/qt/maininterface/compositor_dcomp_acrylicsurface.hpp


Changes:

=====================================
modules/gui/qt/maininterface/compositor_dcomp.cpp
=====================================
@@ -45,7 +45,7 @@ namespace vlc {
 using namespace Microsoft::WRL;
 
 //Signature for DCompositionCreateDevice
-typedef HRESULT (*DCompositionCreateDeviceFun)(IDXGIDevice *dxgiDevice, REFIID iid, void** dcompositionDevice);
+typedef HRESULT (WINAPI* DCompositionCreateDeviceFun)(IDXGIDevice *dxgiDevice, REFIID iid, void** dcompositionDevice);
 
 int CompositorDirectComposition::windowEnable(const vlc_window_cfg_t *)
 {


=====================================
modules/gui/qt/maininterface/compositor_dcomp_acrylicsurface.hpp
=====================================
@@ -151,7 +151,7 @@ typedef BOOL(WINAPI* GetWindowCompositionAttribute)(
 );
 
 //Signature for DCompositionCreateDevice
-typedef HRESULT (*DCompositionCreateDeviceFun)(IDXGIDevice *dxgiDevice, REFIID iid, void** dcompositionDevice);
+typedef HRESULT (WINAPI* DCompositionCreateDeviceFun)(IDXGIDevice *dxgiDevice, REFIID iid, void** dcompositionDevice);
 
 namespace vlc
 {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/2eeada263f3f9db1784a446d96929e65c81c481c

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/2eeada263f3f9db1784a446d96929e65c81c481c
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list