[vlc-commits] [Git][videolan/vlc][master] qml/SliderBar: Apply position inside 'onCompleted'

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
ff920de8 by Benjamin Arnaud at 2023-04-23T10:15:32+00:00
qml/SliderBar: Apply position inside 'onCompleted'

Calling the state machine signal does not seem to be a good idea given the Connection(s)
items are not fully loaded. This fixes an issue of the Player position not being applied
when loading the SliderBar.

- - - - -


1 changed file:

- modules/gui/qt/player/qml/SliderBar.qml


Changes:

=====================================
modules/gui/qt/player/qml/SliderBar.qml
=====================================
@@ -153,9 +153,7 @@ Slider {
         onPositionChanged: fsm.playerUpdatePosition(Player.position)
     }
 
-    Component.onCompleted:  {
-        fsm.playerUpdatePosition(Player.position)
-    }
+    Component.onCompleted: value = Player.position
 
     implicitHeight: control.barHeight
     height: implicitHeight



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/ff920de8e5ca56e41b72dd00fa606fe4c376aca7

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/ff920de8e5ca56e41b72dd00fa606fe4c376aca7
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance