[vlc-commits] [Git][videolan/vlc][master] test: opengl/filters: fix test failure

Steve Lhomme (@robUx4) gitlab at videolan.org
Wed Aug 2 08:17:40 UTC 2023



Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
1bf7f318 by Alexandre Janniaux at 2023-08-02T07:46:44+00:00
test: opengl/filters: fix test failure

The video_format_t structure was not initialized to zero and
video_format_Setup was not setting everything fields as expected,
leading to .lighting and .mastering being non-zero. After the bad
commit, those values were used and changing the values from the test
where zero was expected to non-zero.

First bad commit was 85a04a2ef8865f23b0323803bd550b3bd2829ede.

- - - - -


1 changed file:

- test/modules/video_output/opengl/filters.c


Changes:

=====================================
test/modules/video_output/opengl/filters.c
=====================================
@@ -99,10 +99,11 @@ static void test_opengl_offscreen(
     GL_ASSERT_NOERROR(&api.vt);
 
     video_format_t fmt;
+    video_format_Init(&fmt, VLC_CODEC_RGBA);
     video_format_Setup(&fmt, VLC_CODEC_RGBA, 3, 3, 3, 3, 1, 1);
-    fmt.primaries = COLOR_PRIMARIES_SRGB;
-    fmt.space = COLOR_SPACE_SRGB;
-    fmt.transfer = TRANSFER_FUNC_SRGB;
+    fmt.primaries = COLOR_PRIMARIES_UNDEF;
+    fmt.space = COLOR_SPACE_UNDEF;
+    fmt.transfer = TRANSFER_FUNC_UNDEF;
     fmt.projection_mode = PROJECTION_MODE_RECTANGULAR;
 
     struct vlc_gl_interop *interop =



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/1bf7f3181a55a3d69ff7419933b3ec801277f1f2

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/1bf7f3181a55a3d69ff7419933b3ec801277f1f2
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list