[vlc-commits] [Git][videolan/vlc][master] 2 commits: package/macos: add an option to compile with extra checks

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
3ec8a6e0 by Steve Lhomme at 2023-08-19T16:19:47+00:00
package/macos: add an option to compile with extra checks

This is similar to the option found in win32 and raspberry builds.

- - - - -
3aca4f30 by Steve Lhomme at 2023-08-19T16:19:47+00:00
CI: build macosx targets with extra pointer checks

The CFLAGS can't be set globally when calling build.sh as it would apply
to contribs and tools which we don't require to be extra clean.

- - - - -


2 changed files:

- extras/ci/gitlab-ci.yml
- extras/package/macosx/build.sh


Changes:

=====================================
extras/ci/gitlab-ci.yml
=====================================
@@ -477,7 +477,7 @@ raspbian-arm:
         fi
         export PATH="${VLC_PATH}:$PATH"
         mkdir build && cd build
-        ../extras/package/macosx/build.sh $EXTRA_BUILD_FLAGS $NIGHTLY_EXTRA_BUILD_FLAGS -a $HOST_ARCH
+        ../extras/package/macosx/build.sh $EXTRA_BUILD_FLAGS $NIGHTLY_EXTRA_BUILD_FLAGS -a $HOST_ARCH -x
 
 macos-x86_64:
     extends: .macos-common


=====================================
extras/package/macosx/build.sh
=====================================
@@ -44,6 +44,7 @@ OPTIONS:
                      g: GPLv3 (default)
                      l: LGPLv3 + ad-clauses
                      a: LGPLv2 + ad-clauses
+   -x            Add extra checks when compiling
 EOF
 
 }
@@ -58,7 +59,7 @@ spopd()
     popd > /dev/null
 }
 
-while getopts "qhvrcdpi:k:a:j:C:b:g:" OPTION
+while getopts "qhvrcdpi:k:a:j:C:b:g:x" OPTION
 do
      case $OPTION in
          h)
@@ -102,6 +103,9 @@ do
          g)
              LICENSE=$OPTARG
          ;;
+         x)
+             EXTRA_CHECKS="yes"
+         ;;
          *)
              usage
              exit 1
@@ -247,6 +251,13 @@ fi
 if [ "$NODEBUG" = "yes" ]; then
      CONFIGFLAGS="$CONFIGFLAGS --disable-debug"
 fi
+if [ -n "$EXTRA_CHECKS" ]; then
+    CFLAGS="$CFLAGS -Werror=incompatible-pointer-types -Werror=missing-field-initializers"
+    CXXFLAGS="$CXXFLAGS -Werror=missing-field-initializers"
+fi
+
+export CFLAGS
+export CXXFLAGS
 
 if [ "${vlcroot}/configure" -nt Makefile ]; then
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/2da81597c0caa4200ba45dd638f60933441cc4ef...3aca4f30b01a60dd3dd8b1f02b0fe7dda7a2c55d

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/2da81597c0caa4200ba45dd638f60933441cc4ef...3aca4f30b01a60dd3dd8b1f02b0fe7dda7a2c55d
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance