[vlc-commits] [Git][videolan/vlc][master] qml: disable clipping optimization in FadingEdgeListView

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
901726ac by Fatih Uzunoglu at 2023-02-04T13:18:57+00:00
qml: disable clipping optimization in FadingEdgeListView

Unfortunately elements residing outside of the rendered
viewport receive mouse events this way.

An alternative to this might be adding two additional
MouseAreas to block events reaching outside of the
rendered region, but I did not want to further complicate
this file.

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/FadingEdgeListView.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/FadingEdgeListView.qml
=====================================
@@ -126,16 +126,6 @@ ListView {
                                            (!lastVisibleItem.activeFocus &&
                                             !Helpers.get(lastVisibleItem, "hovered", false)))
 
-    // If Qt < 5.14, have to force clip enable,
-    // because we can not dictate the reused
-    // one to always have a binding assigned
-    // to clip property.
-    Component.onCompleted: {
-        if (!(clipBinding.restoreMode === 3 /* RestoreBindingOrValue */)) {
-            clip = Qt.binding(function() { return true })
-        }
-    }
-
     BindingCompat on disableBeginningFade {
         when: !!root.headerItem && (root.headerPositioning !== ListView.InlineHeader)
         value: true
@@ -146,16 +136,6 @@ ListView {
         value: true
     }
 
-    // When the effect is active,
-    // it will clip inherently.
-    // So the parent does not need
-    // clipping enabled.
-    BindingCompat on clip {
-        id: clipBinding
-        when: proxyContentItem.visible
-        value: false
-    }
-
     ShaderEffectSource {
         id: proxyContentItem
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/901726ac42b2f87c0baf70be3ff69bee63bd21a2

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/901726ac42b2f87c0baf70be3ff69bee63bd21a2
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance