[vlc-commits] [Git][videolan/vlc][master] 47 commits: macosx: Hide static control bar in library window when displaying video

Jean-Baptiste Kempf (@jbk) gitlab at videolan.org
Sat Feb 25 17:27:49 UTC 2023 


Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
0ab55c40 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Hide static control bar in library window when displaying video

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
be1b1369 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Add starter VLCMainVideoView.XIB

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
2aec33da by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Add VLCMainVideoView class

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
ea99a8df by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Fix the static control bar being reshown when the player state changed in video view mode

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
e0f083df by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Remove largely unused videoView property of VLCWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
c9399e7a by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Replace use of VOutView in window subclasses with VLCMainVideoView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
0ac85796 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Improve the design of VLCMainVideoView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
6882a5e5 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Make file owner of VLCMainVideoView a controller class

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
0a72c80d by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Improve VLCMainVideoView button icons

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
df6424a5 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Add new NSBox that darkens voutview as root controls view, making main buttons more visible

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
ab1615a1 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Properly instantiate XIB in VLCMainVideoViewController if initiating with init

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
f1ff0a0b by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Properly instantiate VLCMainVideoViewController in VLCLibraryWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
a8899ea4 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Set blending mode of control bar of VLCMainVideoView to within window manually

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
50edf228 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Autohide the controls in the main video view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
57d3df57 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Ensure the controls are visible on video playback start in library window

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
0ca5d505 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Add back and playlist buttons to VLCMainVideoView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
a1f8f98c by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Adjust button coloration in VLCMainVideoView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
f036c6a6 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: By default only show top buttons in VLCMainVideoView in library window

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
e826dd40 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Make playlist toggle button in VLCMainVideoView functional

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
2a4770b5 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Make library return button in VLCMainVideoView functional

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
76484f1d by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Autohide the titlebar buttons when in the video view mode for the library window

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
abec01b4 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Dynamically adjust the positioning of the library control buttons in VLCMainVideoView according to window titlebar

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
10e0e9e5 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Fix issues with displayLibraryControls in VLCMainVideoViewController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
0529fa2a by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Darken the main video view a bit more when controls active to improve contrast

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
d6c539f3 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Transfer basic volume slider functionality from VLCMainWindowControlsBar to VLCControlsBarCommon

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
fff9d373 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Hook up all the interactive components to the required outlets in VLCMainVideoView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
3d00a231 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Only set timefield alignment in main window controls bar

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
7e18c3ff by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Move mute volume button outlet to VLCControlsBarCommon

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
a155d878 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Remove unused nowPlaying outlet from VLCControlsBarCommon

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
3eb2682c by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Move shuffle and repeat button functionality from VLCControlsBarCommon to VLCMainWindowControlsBar

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
6d926e33 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Update mute volume button image when mute state changes in control bar

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
5d769339 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Remove old fspanel

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
1a874e01 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Remove now unused autohide toolbar

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
ba01957e by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Fix setup of borderless fullscreen video window

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
eb9eb108 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Fix detached windows, remove need for VLCDetachedWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
c17f8a5b by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Remove no longer needed VLCDetachedVideoWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
aefc897d by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Add VLCFullVideoViewWindow class

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
5dc21b06 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Make VLCLibraryWindow a VLCFullVideoViewWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
88bf6569 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Fix crash when detached window is closed and playlist item changes

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
96018154 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Move control bar related functionality only used by VLCLibraryWindow to this class

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
153cd354 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Correctly init base video window classes even if not inited from XIB

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
d3cff4fb by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Make sure not to show window title in VLCFullVideoViewWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
c8f93a27 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Make VLCAspectRatioRetainingWindow a VLCFullVideoViewWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
65d6803a by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Make sure to enable the video titlebar mode for new detached video windows

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
59eb8171 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Enforce correct sizing of video view in library window

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
a143540b by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Fix volume controls in VLCMainVideoView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
c567aa54 by Claudio Cambra at 2023-02-25T17:11:50+00:00
macosx: Fix VLCMainVideoView interactivity in non native full screen mode

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


25 changed files:

- extras/package/macosx/VLC.xcodeproj/project.pbxproj
- modules/gui/macosx/Makefile.am
- − modules/gui/macosx/UI/DetachedVideoWindow.xib
- modules/gui/macosx/UI/VLCLibraryWindow.xib
- + modules/gui/macosx/UI/VLCMainVideoView.xib
- modules/gui/macosx/library/VLCLibraryWindow.h
- modules/gui/macosx/library/VLCLibraryWindow.m
- modules/gui/macosx/library/audio-library/VLCLibraryAudioViewController.m
- modules/gui/macosx/library/video-library/VLCLibraryVideoViewController.m
- modules/gui/macosx/main/macosx.m
- modules/gui/macosx/playlist/VLCPlayerController.m
- − modules/gui/macosx/views/VLCFSPanelDraggableView.m
- modules/gui/macosx/windows/mainwindow/VLCControlsBarCommon.h
- modules/gui/macosx/windows/mainwindow/VLCControlsBarCommon.m
- modules/gui/macosx/windows/mainwindow/VLCMainWindowControlsBar.h
- modules/gui/macosx/windows/mainwindow/VLCMainWindowControlsBar.m
- modules/gui/macosx/windows/video/VLCAspectRatioRetainingVideoWindow.h
- modules/gui/macosx/windows/video/VLCAspectRatioRetainingVideoWindow.m
- − modules/gui/macosx/windows/video/VLCDetachedVideoWindow.h
- − modules/gui/macosx/windows/video/VLCDetachedVideoWindow.m
- − modules/gui/macosx/windows/video/VLCFSPanelController.h
- − modules/gui/macosx/windows/video/VLCFSPanelController.m
- modules/gui/macosx/library/VLCLibraryWindowAutohideToolbar.h → modules/gui/macosx/windows/video/VLCFullVideoViewWindow.h
- modules/gui/macosx/library/VLCLibraryWindowAutohideToolbar.m → modules/gui/macosx/windows/video/VLCFullVideoViewWindow.m
- modules/gui/macosx/views/VLCFSPanelDraggableView.h → modules/gui/macosx/windows/video/VLCMainVideoViewController.h


The diff was not included because it is too large.


View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/77a2d21b59fb9f1991608009c00931a1dab0ea3e...c567aa548e7f9c5292f55de8c56dc4eacef84316

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/77a2d21b59fb9f1991608009c00931a1dab0ea3e...c567aa548e7f9c5292f55de8c56dc4eacef84316
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance

More information about the vlc-commits mailing list