[vlc-commits] [Git][videolan/vlc][master] 4 commits: qt/cliplistmodel: Add TODO for 'search' properties

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
9df556c0 by Benjamin Arnaud at 2023-01-27T09:25:50+00:00
qt/cliplistmodel: Add TODO for 'search' properties

- - - - -
68932b80 by Benjamin Arnaud at 2023-01-27T09:25:50+00:00
qml/KeyNavigableTableView: Keep the header visible

- - - - -
df1503f9 by Benjamin Arnaud at 2023-01-27T09:25:50+00:00
qml/BrowseDeviceView: Apply 'searchPattern' on a partial list

- - - - -
f4e615a2 by Benjamin Arnaud at 2023-01-27T09:25:50+00:00
qml/BrowseHomeDisplay: Remove capping when filtering

- - - - -


4 changed files:

- modules/gui/qt/network/qml/BrowseDeviceView.qml
- modules/gui/qt/network/qml/BrowseHomeDisplay.qml
- modules/gui/qt/util/cliplistmodel.hpp
- modules/gui/qt/widgets/qml/KeyNavigableTableView.qml


Changes:

=====================================
modules/gui/qt/network/qml/BrowseDeviceView.qml
=====================================
@@ -202,8 +202,7 @@ FocusScope {
 
         searchRole: "name"
 
-        // TODO: Handle the searchPattern on a partial list.
-        searchPattern: (sourceModel && maximumRows === -1) ? sourceModel.searchPattern : ""
+        searchPattern: (sourceModel) ? sourceModel.searchPattern : ""
     }
 
     Widgets.StackViewExt {


=====================================
modules/gui/qt/network/qml/BrowseHomeDisplay.qml
=====================================
@@ -116,7 +116,8 @@ FocusScope {
                 width: flickable.width
                 height: contentHeight
 
-                maximumRows: root.maximumRows
+                // NOTE: We are not capping the list when filtering.
+                maximumRows: (model.searchPattern === "") ? root.maximumRows : -1
 
                 visible: (model.count !== 0)
 
@@ -152,7 +153,7 @@ FocusScope {
                 width: flickable.width
                 height: contentHeight
 
-                maximumRows: root.maximumRows
+                maximumRows: foldersSection.maximumRows
 
                 visible: (model.count !== 0)
 
@@ -199,7 +200,7 @@ FocusScope {
                 width: flickable.width
                 height: contentHeight
 
-                maximumRows: root.maximumRows
+                maximumRows: foldersSection.maximumRows
 
                 visible: (model.count !== 0)
 


=====================================
modules/gui/qt/util/cliplistmodel.hpp
=====================================
@@ -30,6 +30,7 @@
 
 // NOTE: Qt won't let us inherit from QAbstractListModel when declaring a template class. So we
 //       specify a base class for properties and signals.
+// TODO: Implement searchRole and searchPattern.
 class BaseClipListModel : public QAbstractListModel
 {
     Q_OBJECT


=====================================
modules/gui/qt/widgets/qml/KeyNavigableTableView.qml
=====================================
@@ -258,7 +258,6 @@ FocusScope {
             width: view.width
             height: col.height
             color: headerColor
-            visible: view.count > 0
             z: 3
 
             // with inline header positioning and for `root.header` which changes it's height after loading,



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/6d33f4fe120cc3ec60ffb7fa6b7a08fe79a6f237...f4e615a286ddfbf47272ca065467aa989c0e0caf

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/6d33f4fe120cc3ec60ffb7fa6b7a08fe79a6f237...f4e615a286ddfbf47272ca065467aa989c0e0caf
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance