[vlc-commits] [Git][videolan/vlc][master] 3 commits: package/win32: enable -Werror=restrict for Windows gcc builds

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
28dfe768 by Steve Lhomme at 2023-01-29T12:38:17+00:00
package/win32: enable -Werror=restrict for Windows gcc builds

It is supported in gcc8+ which we have in the docker image.
This is a C only option.

- - - - -
6661aaa7 by Steve Lhomme at 2023-01-29T12:38:17+00:00
CI: enable -Werror=restrict for Windows gcc builds

It is supported in gcc8+ which we have in the docker image.
This is a C only option.

- - - - -
3192d429 by Steve Lhomme at 2023-01-29T12:38:17+00:00
CI: enable -Werror=restrict for Debian (gcc) builds

It is supported in gcc8+ which we have in the docker image.
This is a C only option.

- - - - -


2 changed files:

- extras/ci/gitlab-ci.yml
- extras/package/win32/build.sh


Changes:

=====================================
extras/ci/gitlab-ci.yml
=====================================
@@ -155,13 +155,17 @@ win32:
     extends: .win-common
     image:
         name: $VLC_WIN32_IMAGE
-    variables: *variables-win32
+    variables:
+        <<: *variables-win32
+        LIBVLC_EXTRA_BUILD_FLAGS: -x
 
 win64:
     extends: .win-common
     image:
         name: $VLC_WIN64_IMAGE
-    variables: *variables-win64
+    variables:
+        <<: *variables-win64
+        LIBVLC_EXTRA_BUILD_FLAGS: -x
 
 win64-llvm:
     extends: .win-common
@@ -283,7 +287,7 @@ debian:
 
         # Configure VLC
         ./bootstrap
-        ./configure
+        ./configure CFLAGS="$LIBVLC_EXTRA_CFLAGS"
 
         # Allow core dumps for tracing test failures
         ulimit -c unlimited
@@ -291,7 +295,9 @@ debian:
         # Build, check and distcheck VLC
         export XZ_OPT="-T 0"
         VLC_TEST_TIMEOUT=60 make -j$NCPU distcheck || ./test/dump_stacktraces.sh
-    variables: *variables-debian
+    variables:
+        <<: *variables-debian
+        LIBVLC_EXTRA_CFLAGS: -Werror=restrict
 
 nightly-debian:
     extends: debian


=====================================
extras/package/win32/build.sh
=====================================
@@ -407,6 +407,9 @@ fi
 if [ ! -z "$EXTRA_CHECKS" ]; then
     CFLAGS="$CFLAGS -Werror=incompatible-pointer-types -Werror=missing-field-initializers"
     CXXFLAGS="$CXXFLAGS -Werror=missing-field-initializers"
+    if [ ! "$COMPILING_WITH_CLANG" -gt 0 ]; then
+        CFLAGS="$CFLAGS -Werror=restrict"
+    fi
 fi
 if [ ! -z "$DISABLEGUI" ]; then
     CONFIGFLAGS="$CONFIGFLAGS --disable-vlc --disable-qt --disable-skins2"



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/f28a4b2b34be9cc3d342c258d698c8f34751205e...3192d4296f8643bcb0783ffec2838407d9931c70

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/f28a4b2b34be9cc3d342c258d698c8f34751205e...3192d4296f8643bcb0783ffec2838407d9931c70
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance