[vlc-commits] [Git][videolan/vlc][master] 2 commits: macosx: Fix insets for audio library split view collection view

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
1b229c1a by Claudio Cambra at 2023-01-31T10:17:14+00:00
macosx: Fix insets for audio library split view collection view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
0eaa2991 by Claudio Cambra at 2023-01-31T10:17:14+00:00
macosx: Make all scroll view insets in main library scroll views equal

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


1 changed file:

- modules/gui/macosx/library/VLCLibraryWindow.m


Changes:

=====================================
modules/gui/macosx/library/VLCLibraryWindow.m
=====================================
@@ -250,13 +250,10 @@ static void addShadow(NSImageView *__unsafe_unretained imageView)
     [self repeatStateUpdated:nil];
     [self shuffleStateUpdated:nil];
 
-    // We want all the insets to look even, and since the scrollbar is transparent,
-    // we have to compensate for this on the sides where there isn't a scrollbar to
-    // match up the perceived whitespace on all sides
-    const CGFloat scrollViewTopInset = [VLCLibraryUIUnits scrollBarSmallSideSize];
-    const CGFloat scrollViewRightInset = 0.;
-    const CGFloat scrollViewBottomInset = [VLCLibraryUIUnits scrollBarSmallSideSize];
-    const CGFloat scrollViewLeftInset = [VLCLibraryUIUnits scrollBarSmallSideSize];
+    const CGFloat scrollViewTopInset = [VLCLibraryUIUnits mediumSpacing];
+    const CGFloat scrollViewRightInset = [VLCLibraryUIUnits mediumSpacing];
+    const CGFloat scrollViewBottomInset = [VLCLibraryUIUnits mediumSpacing];
+    const CGFloat scrollViewLeftInset = [VLCLibraryUIUnits mediumSpacing];
 
     // Need to account for the audio collection switcher at the top
     const CGFloat audioScrollViewTopInset = scrollViewTopInset + _optionBarView.frame.size.height;
@@ -325,9 +322,9 @@ static void addShadow(NSImageView *__unsafe_unretained imageView)
     audioLibraryCollectionViewLayout.sectionInset = collectionViewSectionInset;
 
     NSCollectionViewFlowLayout *audioLibraryGridModeListSelectionCollectionViewLayout = _audioLibraryGridModeSplitViewListSelectionCollectionView.collectionViewLayout;
-    audioLibraryGridModeListSelectionCollectionViewLayout.itemSize = [VLCLibraryCollectionViewItem defaultSize];
     audioLibraryGridModeListSelectionCollectionViewLayout.minimumLineSpacing = collectionItemSpacing;
     audioLibraryGridModeListSelectionCollectionViewLayout.minimumInteritemSpacing = collectionItemSpacing;
+    audioLibraryGridModeListSelectionCollectionViewLayout.sectionInset = collectionViewSectionInset;
 
     VLCLibraryVideoCollectionViewsStackViewController *videoLibraryStackViewController = _libraryVideoViewController.libraryVideoCollectionViewsStackViewController;
     videoLibraryStackViewController.collectionViewItemSize = [VLCLibraryCollectionViewItem defaultVideoItemSize];



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/9cb9df5097a47272cffdcf205a49c27c59ead18d...0eaa299187c9710a65cf57f7b5a572c323c5dd9e

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/9cb9df5097a47272cffdcf205a49c27c59ead18d...0eaa299187c9710a65cf57f7b5a572c323c5dd9e
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance