[vlc-commits] [Git][videolan/vlc][master] qml: fix toolbar editor dialog combobox sizing

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
2807d7ad by Fatih Uzunoglu at 2023-07-20T12:20:59+00:00
qml: fix toolbar editor dialog combobox sizing

- - - - -


1 changed file:

- modules/gui/qt/dialogs/toolbar/qml/ToolbarEditorDialog.qml


Changes:

=====================================
modules/gui/qt/dialogs/toolbar/qml/ToolbarEditorDialog.qml
=====================================
@@ -69,9 +69,17 @@ WindowDialog {
         ColumnLayout {
             anchors.fill: parent
 
+            spacing: VLCStyle.margin_small
+
             RowLayout {
+                Layout.fillHeight: false
+
+                spacing: VLCStyle.margin_xsmall
+
                 Widgets.MenuLabel {
                     Layout.fillWidth: true
+                    Layout.minimumWidth: implicitWidth
+
                     color: root.colorContext.fg.primary
                     text: I18n.qtr("Select profile:")
                 }
@@ -79,13 +87,16 @@ WindowDialog {
                 Widgets.ComboBoxExt {
                     id: comboBox
 
-                    Layout.maximumWidth: (root.width / 2)
+                    Layout.fillWidth: (implicitWidth > Layout.minimumWidth)
+                    Layout.minimumWidth: VLCStyle.combobox_width_large
+                    Layout.minimumHeight: VLCStyle.combobox_height_normal
 
+                    // this is not proper way to do it,
+                    // but ComboBoxExt does not provide
+                    // correct implicit width:
+                    implicitWidth: implicitContentWidth
                     font.pixelSize: VLCStyle.fontSize_normal
 
-                    width: VLCStyle.combobox_width_large
-                    height: VLCStyle.combobox_height_normal
-
                     delegate: ItemDelegate {
                         width: comboBox.width
                         leftPadding: comboBox.leftPadding



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/2807d7adf972f8f7613eb2e381b4f5d8aa5798ee

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/2807d7adf972f8f7613eb2e381b4f5d8aa5798ee
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance