[vlc-commits] [Git][videolan/vlc][3.0.x] 6 commits: d3d11_fmt: allow logging DXGI/D3D11 resources at any time

Jean-Baptiste Kempf (@jbk) gitlab at videolan.org
Sun Mar 26 11:23:38 UTC 2023



Jean-Baptiste Kempf pushed to branch 3.0.x at VideoLAN / VLC


Commits:
90398c75 by Steve Lhomme at 2023-03-26T11:06:51+00:00
d3d11_fmt: allow logging DXGI/D3D11 resources at any time

(cherry picked from commit 9d7a6264cbbd8387a4772d665f4949f1d081b8a7) (rebased)

rebased:
* pDXGIDebug is released on current 3.0

Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>

- - - - -
cf738839 by Steve Lhomme at 2023-03-26T11:06:51+00:00
d3d11_fmt: always initialize DXGI debug fields

(cherry picked from commit 94ab4cda9e8fa129f85c52eb38cea699018b51d7)

Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>

- - - - -
984f8d27 by Steve Lhomme at 2023-03-26T11:06:51+00:00
d3d11_fmt: keep the DXGI adapter description with the device

Since we always check it.

Read it as soon as the d3d11_device_t is created.

(cherry picked from commit fc6194d56c799b061222c7312f657ec4339fd521) (edited)

edited:
* D3D11_GetDriverVersion is kept public as we don't use a decoder device
* we have dummy D3D11_GetDriverVersion for UWP in 3.0
* we don't have a DXGI adapter when creating the ID3D11Device

Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>

- - - - -
8613ddd7 by Steve Lhomme at 2023-03-26T11:06:51+00:00
d3d11: use the stored DXGI Adpater Description

Instead of reading it each time.

(cherry picked from commit 25640567c2e8726539b9eb0656505f13cbe245a2) (edited)

edited:
* the 3.0 directx_va_Setup() call is different
* 3.0 uses DxDescribe to get the decoder string

Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>

- - - - -
71e4ef41 by Steve Lhomme at 2023-03-26T11:06:51+00:00
direct3d11: fix missing fence reset

- - - - -
ce21489a by Steve Lhomme at 2023-03-26T11:06:51+00:00
direct3d11: separate the code to set shader samplers

- - - - -


4 changed files:

- modules/codec/avcodec/d3d11va.c
- modules/video_chroma/d3d11_fmt.c
- modules/video_chroma/d3d11_fmt.h
- modules/video_output/win32/direct3d11.c


Changes:

=====================================
modules/codec/avcodec/d3d11va.c
=====================================
@@ -368,6 +368,12 @@ static int Open(vlc_va_t *va, AVCodecContext *ctx, enum PixelFormat pix_fmt,
 
             sys->d3d_dev.d3dcontext = p_sys->context;
             sys->d3d_dev.owner = false;
+            IDXGIAdapter *adap = D3D11DeviceAdapter(sys->d3d_dev.d3ddevice);
+            if (adap != NULL)
+            {
+                hr = IDXGIAdapter_GetDesc(adap, &sys->d3d_dev.adapterDesc);
+                IDXGIAdapter_Release(adap);
+            }
             D3D11_GetDriverVersion(va, &sys->d3d_dev);
             sys->d3dvidctx = d3dvidctx;
 
@@ -392,7 +398,7 @@ static int Open(vlc_va_t *va, AVCodecContext *ctx, enum PixelFormat pix_fmt,
     if (err!=VLC_SUCCESS)
         goto error;
 
-    err = directx_va_Setup(va, &sys->dx_sys, ctx, fmt, isXboxHardware(sys->d3d_dev.d3ddevice));
+    err = directx_va_Setup(va, &sys->dx_sys, ctx, fmt, isXboxHardware(&sys->d3d_dev));
     if (err != VLC_SUCCESS)
         goto error;
 
@@ -470,27 +476,18 @@ static void D3dDestroyDevice(vlc_va_t *va)
  */
 static char *DxDescribe(vlc_va_sys_t *sys)
 {
-
-    IDXGIAdapter *p_adapter = D3D11DeviceAdapter(sys->d3d_dev.d3ddevice);
-    if (!p_adapter) {
-       return NULL;
-    }
-
     char *description = NULL;
-    DXGI_ADAPTER_DESC adapterDesc;
-    if (SUCCEEDED(IDXGIAdapter_GetDesc(p_adapter, &adapterDesc))) {
-        char *utfdesc = FromWide(adapterDesc.Description);
-        if (likely(utfdesc!=NULL))
-        {
-            if (asprintf(&description, "D3D11VA (%s, vendor %x(%s), device %x, revision %x)",
-                         utfdesc,
-                         adapterDesc.VendorId, DxgiVendorStr(adapterDesc.VendorId), adapterDesc.DeviceId, adapterDesc.Revision) < 0)
-                description = NULL;
-            free(utfdesc);
-        }
+    char *utfdesc = FromWide(sys->d3d_dev.adapterDesc.Description);
+    if (likely(utfdesc!=NULL))
+    {
+        if (asprintf(&description, "D3D11VA (%s, vendor %x(%s), device %x, revision %x)",
+                        utfdesc,
+                        sys->d3d_dev.adapterDesc.VendorId, DxgiVendorStr(sys->d3d_dev.adapterDesc.VendorId),
+                        sys->d3d_dev.adapterDesc.DeviceId, sys->d3d_dev.adapterDesc.Revision) < 0)
+            description = NULL;
+        free(utfdesc);
     }
 
-    IDXGIAdapter_Release(p_adapter);
     return description;
 }
 
@@ -572,19 +569,9 @@ static int DxSetupOutput(vlc_va_t *va, const GUID *input, const video_format_t *
     }
 #endif
 
-    IDXGIAdapter *pAdapter = D3D11DeviceAdapter(sys->d3d_dev.d3ddevice);
-    if (!pAdapter)
-        return VLC_EGENERIC;
-
-    DXGI_ADAPTER_DESC adapterDesc;
-    hr = IDXGIAdapter_GetDesc(pAdapter, &adapterDesc);
-    IDXGIAdapter_Release(pAdapter);
-    if (FAILED(hr))
-        return VLC_EGENERIC;
-
     char *psz_decoder_name = directx_va_GetDecoderName(input);
 
-    if (!directx_va_canUseDecoder(va, adapterDesc.VendorId, adapterDesc.DeviceId,
+    if (!directx_va_canUseDecoder(va, sys->d3d_dev.adapterDesc.VendorId, sys->d3d_dev.adapterDesc.DeviceId,
                                   input, sys->d3d_dev.WDDM.build))
     {
         msg_Warn(va, "GPU blacklisted for %s codec", psz_decoder_name);
@@ -673,21 +660,11 @@ static int DxSetupOutput(vlc_va_t *va, const GUID *input, const video_format_t *
     return VLC_EGENERIC;
 }
 
-static bool CanUseDecoderPadding(vlc_va_sys_t *sys)
+static bool CanUseDecoderPadding(const vlc_va_sys_t *sys)
 {
-    IDXGIAdapter *pAdapter = D3D11DeviceAdapter(sys->d3d_dev.d3ddevice);
-    if (!pAdapter)
-        return false;
-
-    DXGI_ADAPTER_DESC adapterDesc;
-    HRESULT hr = IDXGIAdapter_GetDesc(pAdapter, &adapterDesc);
-    IDXGIAdapter_Release(pAdapter);
-    if (FAILED(hr))
-        return false;
-
     /* Qualcomm hardware has issues with textures and pixels that should not be
     * part of the decoded area */
-    return adapterDesc.VendorId != GPU_MANUFACTURER_QUALCOMM;
+    return sys->d3d_dev.adapterDesc.VendorId != GPU_MANUFACTURER_QUALCOMM;
 }
 
 /**
@@ -733,7 +710,7 @@ static int DxCreateDecoderSurfaces(vlc_va_t *va, int codec_id,
      * crashes totally the device */
     if (codec_id == AV_CODEC_ID_H264 &&
         (sys->textureWidth > 2304 || sys->textureHeight > 2304) &&
-        isXboxHardware(sys->d3d_dev.d3ddevice))
+        isXboxHardware(&sys->d3d_dev))
     {
         msg_Warn(va, "%dx%d resolution not supported by your hardware", fmt->i_width, fmt->i_height);
         return VLC_EGENERIC;


=====================================
modules/video_chroma/d3d11_fmt.c
=====================================
@@ -182,26 +182,10 @@ void D3D11_GetDriverVersion(vlc_object_t *obj, d3d11_device_t *d3d_dev)
 {
     memset(&d3d_dev->WDDM, 0, sizeof(d3d_dev->WDDM));
 
-    IDXGIAdapter *pAdapter = D3D11DeviceAdapter(d3d_dev->d3ddevice);
-    if (unlikely(!pAdapter))
-    {
-        msg_Warn(obj, "can't get adapter from device %p", (void*)d3d_dev->d3ddevice);
-        return;
-    }
-
-    DXGI_ADAPTER_DESC adapterDesc;
-    HRESULT hr = IDXGIAdapter_GetDesc(pAdapter, &adapterDesc);
-    IDXGIAdapter_Release(pAdapter);
-    if (FAILED(hr))
-    {
-        msg_Warn(obj, "can't get adapter description");
-        return;
-    }
-
     LONG err = ERROR_ACCESS_DENIED;
     CHAR szData[256];
     DWORD len = 256;
-    HKEY hKey = GetAdapterRegistry(obj, &adapterDesc);
+    HKEY hKey = GetAdapterRegistry(obj, &d3d_dev->adapterDesc);
     if (hKey == NULL)
     {
         msg_Warn(obj, "can't find adapter in registry");
@@ -228,8 +212,8 @@ void D3D11_GetDriverVersion(vlc_object_t *obj, d3d11_device_t *d3d_dev)
     d3d_dev->WDDM.d3d_features = d3d_features;
     d3d_dev->WDDM.revision     = revision;
     d3d_dev->WDDM.build        = build;
-    msg_Dbg(obj, "%s WDDM driver %d.%d.%d.%d", DxgiVendorStr(adapterDesc.VendorId), wddm, d3d_features, revision, build);
-    if (adapterDesc.VendorId == GPU_MANUFACTURER_INTEL && revision >= 100)
+    msg_Dbg(obj, "%s WDDM driver %d.%d.%d.%d", DxgiVendorStr(d3d_dev->adapterDesc.VendorId), wddm, d3d_features, revision, build);
+    if (d3d_dev->adapterDesc.VendorId == GPU_MANUFACTURER_INTEL && revision >= 100)
     {
         /* new Intel driver format */
         d3d_dev->WDDM.build += (revision - 100) * 1000;
@@ -320,6 +304,19 @@ HRESULT D3D11_CreateDevice(vlc_object_t *obj, d3d11_handle_t *hd3d,
         if (SUCCEEDED(hr)) {
             msg_Dbg(obj, "Created the D3D11 device type %d level %x.",
                     driverAttempts[driver], out->feature_level);
+            {
+                IDXGIAdapter *adap = D3D11DeviceAdapter(out->d3ddevice);
+                if (adap == NULL)
+                    hr = E_FAIL;
+                else
+                {
+                    hr = IDXGIAdapter_GetDesc(adap, &out->adapterDesc);
+                    IDXGIAdapter_Release(adap);
+                }
+            }
+            if (hr)
+                msg_Warn(obj, "can't get adapter description");
+
             D3D11_GetDriverVersion( obj, out );
             /* we can work with legacy levels but only if forced */
             if ( obj->obj.force || out->feature_level >= D3D_FEATURE_LEVEL_11_0 )
@@ -364,22 +361,15 @@ IDXGIAdapter *D3D11DeviceAdapter(ID3D11Device *d3ddev)
     return p_adapter;
 }
 
-bool isXboxHardware(ID3D11Device *d3ddev)
+bool isXboxHardware(const d3d11_device_t *d3ddev)
 {
-    IDXGIAdapter *p_adapter = D3D11DeviceAdapter(d3ddev);
-    if (!p_adapter)
-        return NULL;
-
     bool result = false;
-    DXGI_ADAPTER_DESC adapterDesc;
-    if (SUCCEEDED(IDXGIAdapter_GetDesc(p_adapter, &adapterDesc))) {
-        if (adapterDesc.VendorId == 0 &&
-            adapterDesc.DeviceId == 0 &&
-            !wcscmp(L"ROOT\\SraKmd\\0000", adapterDesc.Description))
-            result = true;
-    }
 
-    IDXGIAdapter_Release(p_adapter);
+    if (d3ddev->adapterDesc.VendorId == 0 &&
+        d3ddev->adapterDesc.DeviceId == 0 &&
+        !wcscmp(L"ROOT\\SraKmd\\0000", d3ddev->adapterDesc.Description))
+        result = true;
+
     return result;
 }
 
@@ -410,19 +400,9 @@ bool CanUseVoutPool(d3d11_device_t *d3d_dev, UINT slices)
 #endif
 }
 
-int D3D11CheckDriverVersion(d3d11_device_t *d3d_dev, UINT vendorId, const struct wddm_version *min_ver)
+int D3D11CheckDriverVersion(const d3d11_device_t *d3d_dev, UINT vendorId, const struct wddm_version *min_ver)
 {
-    IDXGIAdapter *pAdapter = D3D11DeviceAdapter(d3d_dev->d3ddevice);
-    if (!pAdapter)
-        return VLC_EGENERIC;
-
-    DXGI_ADAPTER_DESC adapterDesc;
-    HRESULT hr = IDXGIAdapter_GetDesc(pAdapter, &adapterDesc);
-    IDXGIAdapter_Release(pAdapter);
-    if (FAILED(hr))
-        return VLC_EGENERIC;
-
-    if (vendorId && adapterDesc.VendorId != vendorId)
+    if (vendorId && d3d_dev->adapterDesc.VendorId != vendorId)
         return VLC_SUCCESS;
 
     if (min_ver->wddm)
@@ -711,31 +691,49 @@ int D3D11_Create(vlc_object_t *obj, d3d11_handle_t *hd3d, bool with_shaders)
             return VLC_EGENERIC;
         }
     }
-#endif
-    return VLC_SUCCESS;
-}
-
-void D3D11_Destroy(d3d11_handle_t *hd3d)
-{
-#if !VLC_WINSTORE_APP
 # if !defined(NDEBUG) && defined(HAVE_DXGIDEBUG_H)
+    hd3d->dxgidebug_dll = NULL;
+    hd3d->pf_DXGIGetDebugInterface = NULL;
     if (IsDebuggerPresent())
     {
         hd3d->dxgidebug_dll = LoadLibrary(TEXT("DXGIDEBUG.DLL"));
-        HRESULT (WINAPI * pf_DXGIGetDebugInterface)(const GUID *riid, void **ppDebug) = NULL;
         if (hd3d->dxgidebug_dll)
-            pf_DXGIGetDebugInterface =
+        {
+            hd3d->pf_DXGIGetDebugInterface =
                     (void *)GetProcAddress(hd3d->dxgidebug_dll, "DXGIGetDebugInterface");
-        if (pf_DXGIGetDebugInterface) {
-            IDXGIDebug *pDXGIDebug;
-            if (SUCCEEDED(pf_DXGIGetDebugInterface(&IID_IDXGIDebug, (void**)&pDXGIDebug)))
+            if (unlikely(!hd3d->pf_DXGIGetDebugInterface))
             {
-                IDXGIDebug_ReportLiveObjects(pDXGIDebug, DXGI_DEBUG_ALL, DXGI_DEBUG_RLO_ALL);
-                IDXGIDebug_Release(pDXGIDebug);
+                FreeLibrary(hd3d->dxgidebug_dll);
+                hd3d->dxgidebug_dll = NULL;
             }
         }
     }
+# endif // !NDEBUG && HAVE_DXGIDEBUG_H
+#endif
+    return VLC_SUCCESS;
+}
+
+void D3D11_LogResources(d3d11_handle_t *hd3d)
+{
+#if !VLC_WINSTORE_APP
+# if !defined(NDEBUG) && defined(HAVE_DXGIDEBUG_H)
+    if (hd3d->pf_DXGIGetDebugInterface)
+    {
+        IDXGIDebug *pDXGIDebug;
+        if (SUCCEEDED(hd3d->pf_DXGIGetDebugInterface(&IID_IDXGIDebug, (void**)&pDXGIDebug)))
+        {
+            IDXGIDebug_ReportLiveObjects(pDXGIDebug, DXGI_DEBUG_ALL, DXGI_DEBUG_RLO_ALL);
+            IDXGIDebug_Release(pDXGIDebug);
+        }
+    }
 # endif
+#endif
+}
+
+void D3D11_Destroy(d3d11_handle_t *hd3d)
+{
+    D3D11_LogResources(hd3d);
+#if !VLC_WINSTORE_APP
     if (hd3d->hdll)
         FreeLibrary(hd3d->hdll);
 


=====================================
modules/video_chroma/d3d11_fmt.h
=====================================
@@ -44,6 +44,7 @@ typedef struct
     HANDLE                   context_mutex;
     struct wddm_version      WDDM;
     D3D_FEATURE_LEVEL        feature_level;
+    DXGI_ADAPTER_DESC        adapterDesc;
 } d3d11_device_t;
 
 typedef struct
@@ -54,6 +55,7 @@ typedef struct
     pD3DCompile               OurD3DCompile;
 #if !defined(NDEBUG) && defined(HAVE_DXGIDEBUG_H)
     HINSTANCE                 dxgidebug_dll;
+    HRESULT (WINAPI * pf_DXGIGetDebugInterface)(const GUID *riid, void **ppDebug);
 #endif
 #endif
 } d3d11_handle_t;
@@ -109,11 +111,12 @@ int D3D11_Create(vlc_object_t *, d3d11_handle_t *, bool with_shaders);
 #define D3D11_Create(a,b,c) D3D11_Create( VLC_OBJECT(a), b, c )
 
 void D3D11_Destroy(d3d11_handle_t *);
+void D3D11_LogResources(d3d11_handle_t *);
 
-bool isXboxHardware(ID3D11Device *d3ddev);
+bool isXboxHardware(const d3d11_device_t *);
 bool CanUseVoutPool(d3d11_device_t *, UINT slices);
 IDXGIAdapter *D3D11DeviceAdapter(ID3D11Device *d3ddev);
-int D3D11CheckDriverVersion(d3d11_device_t *, UINT vendorId,
+int D3D11CheckDriverVersion(const d3d11_device_t *, UINT vendorId,
                             const struct wddm_version *min_ver);
 void D3D11_GetDriverVersion(vlc_object_t *, d3d11_device_t *);
 #define D3D11_GetDriverVersion(a,b) D3D11_GetDriverVersion(VLC_OBJECT(a),b)


=====================================
modules/video_output/win32/direct3d11.c
=====================================
@@ -535,6 +535,48 @@ static void FillSwapChainDesc(vout_display_t *vd, DXGI_SWAP_CHAIN_DESC1 *out)
 }
 #endif
 
+static int UpdateSamplers(vout_display_t *vd)
+{
+    vout_display_sys_t *sys = vd->sys;
+    HRESULT hr;
+
+    D3D11_SAMPLER_DESC sampDesc;
+    memset(&sampDesc, 0, sizeof(sampDesc));
+    sampDesc.AddressU = D3D11_TEXTURE_ADDRESS_CLAMP;
+    sampDesc.AddressV = D3D11_TEXTURE_ADDRESS_CLAMP;
+    sampDesc.AddressW = D3D11_TEXTURE_ADDRESS_CLAMP;
+    sampDesc.ComparisonFunc = D3D11_COMPARISON_ALWAYS;
+    sampDesc.MinLOD = 0;
+    sampDesc.MaxLOD = D3D11_FLOAT32_MAX;
+
+    d3d11_device_lock(&sys->d3d_dev);
+
+    ID3D11SamplerState *d3dsampState[2];
+    sampDesc.Filter = D3D11_FILTER_MIN_MAG_LINEAR_MIP_POINT;
+    hr = ID3D11Device_CreateSamplerState(sys->d3d_dev.d3ddevice, &sampDesc, &d3dsampState[0]);
+    if (FAILED(hr)) {
+        msg_Err(vd, "Could not Create the D3d11 Sampler State. (hr=0x%lX)", hr);
+        d3d11_device_unlock(&sys->d3d_dev);
+        return VLC_EGENERIC;
+    }
+
+    sampDesc.Filter = D3D11_FILTER_MIN_MAG_MIP_POINT;
+    hr = ID3D11Device_CreateSamplerState(sys->d3d_dev.d3ddevice, &sampDesc, &d3dsampState[1]);
+    if (FAILED(hr)) {
+        msg_Err(vd, "Could not Create the D3d11 Sampler State. (hr=0x%lX)", hr);
+        ID3D11SamplerState_Release(d3dsampState[0]);
+        d3d11_device_unlock(&sys->d3d_dev);
+        return VLC_EGENERIC;
+    }
+
+    ID3D11DeviceContext_PSSetSamplers(sys->d3d_dev.d3dcontext, 0, 2, d3dsampState);
+    ID3D11SamplerState_Release(d3dsampState[0]);
+    ID3D11SamplerState_Release(d3dsampState[1]);
+
+    d3d11_device_unlock(&sys->d3d_dev);
+    return VLC_SUCCESS;
+}
+
 static HRESULT UpdateBackBuffer(vout_display_t *vd)
 {
     vout_display_sys_t *sys = vd->sys;
@@ -1004,7 +1046,7 @@ static void Prepare(vout_display_t *vd, picture_t *picture, subpicture_t *subpic
         if (sys->log_level >= 4)
             render_start = mdate();
         if (sys->renderFence == UINT64_MAX)
-            sys->renderFence;
+            sys->renderFence = 0;
         else
             sys->renderFence++;
 
@@ -1515,21 +1557,12 @@ static bool CanUseTextureArray(vout_display_t *vd)
 #endif
 }
 
-static bool BogusZeroCopy(vout_display_t *vd)
+static bool BogusZeroCopy(const vout_display_t *vd)
 {
-    IDXGIAdapter *p_adapter = D3D11DeviceAdapter(vd->sys->d3d_dev.d3ddevice);
-    if (!p_adapter)
-        return false;
-
-    DXGI_ADAPTER_DESC adapterDesc;
-    if (FAILED(IDXGIAdapter_GetDesc(p_adapter, &adapterDesc)))
+    if (vd->sys->d3d_dev.adapterDesc.VendorId != GPU_MANUFACTURER_AMD)
         return false;
-    IDXGIAdapter_Release(p_adapter);
 
-    if (adapterDesc.VendorId != GPU_MANUFACTURER_AMD)
-        return false;
-
-    switch (adapterDesc.DeviceId)
+    switch (vd->sys->d3d_dev.adapterDesc.DeviceId)
     {
     case 0x687F: // RX Vega 56/64
     case 0x6863: // RX Vega Frontier Edition
@@ -1777,34 +1810,7 @@ static int Direct3D11CreateGenericResources(vout_display_t *vd)
 
     UpdatePicQuadPosition(vd);
 
-    D3D11_SAMPLER_DESC sampDesc;
-    memset(&sampDesc, 0, sizeof(sampDesc));
-    sampDesc.Filter = D3D11_FILTER_MIN_MAG_LINEAR_MIP_POINT;
-    sampDesc.AddressU = D3D11_TEXTURE_ADDRESS_CLAMP;
-    sampDesc.AddressV = D3D11_TEXTURE_ADDRESS_CLAMP;
-    sampDesc.AddressW = D3D11_TEXTURE_ADDRESS_CLAMP;
-    sampDesc.ComparisonFunc = D3D11_COMPARISON_ALWAYS;
-    sampDesc.MinLOD = 0;
-    sampDesc.MaxLOD = D3D11_FLOAT32_MAX;
-
-    ID3D11SamplerState *d3dsampState[2];
-    hr = ID3D11Device_CreateSamplerState(sys->d3d_dev.d3ddevice, &sampDesc, &d3dsampState[0]);
-    if (FAILED(hr)) {
-      msg_Err(vd, "Could not Create the D3d11 Sampler State. (hr=0x%lX)", hr);
-      return VLC_EGENERIC;
-    }
-
-    sampDesc.Filter = D3D11_FILTER_MIN_MAG_MIP_POINT;
-    hr = ID3D11Device_CreateSamplerState(sys->d3d_dev.d3ddevice, &sampDesc, &d3dsampState[1]);
-    if (FAILED(hr)) {
-      msg_Err(vd, "Could not Create the D3d11 Sampler State. (hr=0x%lX)", hr);
-      ID3D11SamplerState_Release(d3dsampState[0]);
-      return VLC_EGENERIC;
-    }
-
-    ID3D11DeviceContext_PSSetSamplers(sys->d3d_dev.d3dcontext, 0, 2, d3dsampState);
-    ID3D11SamplerState_Release(d3dsampState[0]);
-    ID3D11SamplerState_Release(d3dsampState[1]);
+    UpdateSamplers(vd);
 
     msg_Dbg(vd, "Direct3D11 resources created");
     return VLC_SUCCESS;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/3e483547037e49f8ef828f2f0455593400968cf4...ce21489a3bc03b89c46b155d2151531eb83860e9

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/3e483547037e49f8ef828f2f0455593400968cf4...ce21489a3bc03b89c46b155d2151531eb83860e9
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list