[vlc-commits] [Git][videolan/vlc][master] vout_subpictures: remove assert on text rendering

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
fcc12de5 by Steve Lhomme at 2023-11-02T10:18:05+00:00
vout_subpictures: remove assert on text rendering

Text-to-speech renderers don't set a new chroma on the output since they
don't create an actual picture.

The code before 7fef0ec0aa049d5433921b7249ce9350e62f04d1 was returning if the
chroma wasn't changed, which is fine for Text-to-speech. There is no picture
to place.

- - - - -


1 changed file:

- src/video_output/vout_subpictures.c


Changes:

=====================================
src/video_output/vout_subpictures.c
=====================================
@@ -812,7 +812,9 @@ static subpicture_region_t *SpuRenderRegion(spu_t *spu,
                       i_original_width, i_original_height,
                       chroma_list) != VLC_SUCCESS)
             return NULL;
-        assert(!subpicture_region_IsText( region ));
+        if(subpicture_region_IsText( region ))
+            // not a rendering error for Text-To-Speech
+            return NULL;
     }
 
     video_format_AdjustColorSpace(&region->fmt);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/fcc12de5197ff1bf9d7262518f55e73a922c0afe

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/fcc12de5197ff1bf9d7262518f55e73a922c0afe
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance