[vlc-commits] [Git][videolan/vlc][master] 2 commits: win32: build.sh: add proper quoting

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
f3dcaf51 by Alexandre Janniaux at 2023-11-10T14:05:07+00:00
win32: build.sh: add proper quoting

The `test` call expects two values between an operator like `=` and the
output of pkg-config can be null. In that case, no argument is given for
an empty string without proper quoting and test signal an error.

- - - - -
dd58d1c0 by Alexandre Janniaux at 2023-11-10T14:05:07+00:00
win32: build.sh: switch to $() instead of ``

- - - - -


1 changed file:

- extras/package/win32/build.sh


Changes:

=====================================
extras/package/win32/build.sh
=====================================
@@ -382,7 +382,7 @@ fi
 cd ../..
 
 if [ -z "$PKG_CONFIG" ]; then
-    if [ `unset PKG_CONFIG_LIBDIR; $TRIPLET-pkg-config --version 1>/dev/null 2>/dev/null || echo FAIL` = "FAIL" ]; then
+    if [ "$(unset PKG_CONFIG_LIBDIR; $TRIPLET-pkg-config --version 1>/dev/null 2>/dev/null || echo FAIL)" = "FAIL" ]; then
         # $TRIPLET-pkg-config DOESNT WORK
         # on Debian it pretends it works to autoconf
         export PKG_CONFIG="pkg-config"



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e374f506a18a29129ca5fc8bd164979cddf9ed3f...dd58d1c0acb1eaca83ae6636de4e731cbea4b022

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e374f506a18a29129ca5fc8bd164979cddf9ed3f...dd58d1c0acb1eaca83ae6636de4e731cbea4b022
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance