[vlc-commits] [Git][videolan/vlc][master] qml: prevent initial visibility change of some items in Player

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
9fc7deb8 by Fatih Uzunoglu at 2023-11-17T11:57:12+00:00
qml: prevent initial visibility change of some items in Player

- - - - -


1 changed file:

- modules/gui/qt/player/qml/Player.qml


Changes:

=====================================
modules/gui/qt/player/qml/Player.qml
=====================================
@@ -468,6 +468,7 @@ FocusScope {
 
                 BindingCompat on visible {
                     delayed: true
+                    when: albumLabel.componentCompleted
                     value: centerContent.height > (albumLabel.y + albumLabel.height)
                 }
 
@@ -476,6 +477,12 @@ FocusScope {
                 horizontalAlignment: Text.AlignHCenter
                 color: centerTheme.fg.primary
                 Accessible.description: I18n.qtr("album")
+
+                property bool componentCompleted: false
+
+                Component.onCompleted: {
+                    componentCompleted = true
+                }
             }
 
             Widgets.MenuLabel {
@@ -486,6 +493,7 @@ FocusScope {
 
                 BindingCompat on visible {
                     delayed: true
+                    when: artistLabel.componentCompleted
                     value: centerContent.height > (artistLabel.y + artistLabel.height)
                 }
 
@@ -494,6 +502,12 @@ FocusScope {
                 horizontalAlignment: Text.AlignHCenter
                 color: centerTheme.fg.primary
                 Accessible.description: I18n.qtr("artist")
+
+                property bool componentCompleted: false
+
+                Component.onCompleted: {
+                    componentCompleted = true
+                }
             }
 
             Widgets.NavigableRow {
@@ -504,6 +518,7 @@ FocusScope {
 
                 BindingCompat on visible {
                     delayed: true
+                    when: audioControls.componentCompleted
                     value: Player.videoTracks.count === 0 && centerContent.height > (audioControls.y + audioControls.height)
                 }
 
@@ -513,6 +528,12 @@ FocusScope {
                 Navigation.upItem: topcontrolView
                 Navigation.downItem: Player.isInteractive ? toggleControlBarButton : controlBarView
 
+                property bool componentCompleted: false
+
+                Component.onCompleted: {
+                    componentCompleted = true
+                }
+
                 model: ObjectModel {
                     Widgets.IconToolButton {
                         iconText: VLCIcons.skip_back



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/9fc7deb8d1b070f2e615fc84b6c0db95a5540d68

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/9fc7deb8d1b070f2e615fc84b6c0db95a5540d68
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance