[vlc-commits] [Git][videolan/vlc][master] 2 commits: qt: fix menus/playlist icon alias

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
06711b16 by Johannes Kauffmann at 2023-11-23T13:16:59+00:00
qt: fix menus/playlist icon alias

In 68fc976d66157bde95eac77d204e02184fb3ff9f, the filename itself was
updated (adding the ic_ prefix). menus.cpp was also updated, but since
menus.cpp depends on the alias name and not the actual filename, this
was causing the following warnings:

    qt.svg: Cannot open file ':/menu/ic_playlist.svg', because: No such file or directory

Thus, update the alias also.

- - - - -
dcafd9f3 by Johannes Kauffmann at 2023-11-23T13:16:59+00:00
qt: fix remove.svg path

Amends f46bef167696c1beddca8af9940dea8399ffbed1.

- - - - -


2 changed files:

- modules/gui/qt/menus/qml_menu_wrapper.cpp
- modules/gui/qt/vlc.qrc


Changes:

=====================================
modules/gui/qt/menus/qml_menu_wrapper.cpp
=====================================
@@ -753,7 +753,7 @@ void PlaylistMediaContextMenu::popup(const QModelIndexList & selected, QPoint po
 
     action = m_menu->addAction(qtr("Remove Selected"));
 
-    action->setIcon(QIcon(":/menu/playlist_remove.svg"));
+    action->setIcon(QIcon(":/menu/remove.svg"));
 
     connect(action, &QAction::triggered, [this, selected]() {
         m_model->remove(selected);


=====================================
modules/gui/qt/vlc.qrc
=====================================
@@ -31,7 +31,7 @@
         <file alias="network.svg">pixmaps/menu/network.svg</file>
         <file alias="ic_fluent_next.svg">pixmaps/menu/ic_fluent_next.svg</file>
         <file alias="ic_pause_filled.svg">pixmaps/menu/ic_pause_filled.svg</file>
-        <file alias="playlist.svg">pixmaps/menu/ic_playlist.svg</file>
+        <file alias="ic_playlist.svg">pixmaps/menu/ic_playlist.svg</file>
         <file alias="ic_fluent_play_filled.svg">pixmaps/menu/ic_fluent_play_filled.svg</file>
         <file alias="preferences.svg">pixmaps/menu/preferences.svg</file>
         <file alias="ic_fluent_previous.svg">pixmaps/menu/ic_fluent_previous.svg</file>



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c886d291aa4c13a7ef47688059dd15e7963d6617...dcafd9f3c049295b0159c94a21cefc7e809c3abb

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c886d291aa4c13a7ef47688059dd15e7963d6617...dcafd9f3c049295b0159c94a21cefc7e809c3abb
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance