[vlc-commits] [Git][videolan/vlc][master] 8 commits: qml: use paintedWidth/paintedHeight for sizing the shadow in ArtworkInfoWidget
Jean-Baptiste Kempf (@jbk)
gitlab at videolan.org
Sun Oct 1 17:07:51 UTC 2023
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC
Commits:
7c8ae829 by Fatih Uzunoglu at 2023-10-01T16:52:34+00:00
qml: use paintedWidth/paintedHeight for sizing the shadow in ArtworkInfoWidget
- - - - -
e22b4706 by Fatih Uzunoglu at 2023-10-01T16:52:34+00:00
qml: change parent of ListCoverShadow in VideoInfoExpandPanel
- - - - -
904270ad by Fatih Uzunoglu at 2023-10-01T16:52:34+00:00
qml: change parent of ListCoverShadow in TableColumns
- - - - -
235d8d68 by Fatih Uzunoglu at 2023-10-01T16:52:34+00:00
qml: remove unnecessary Item in TableColumns
- - - - -
6fd4dbaf by Fatih Uzunoglu at 2023-10-01T16:52:34+00:00
qml: hide shadow in PlaylistDelegate when image is not ready
- - - - -
986e2646 by Fatih Uzunoglu at 2023-10-01T16:52:34+00:00
qml: hide shadow in VideoInfoExpandPanel when image is not ready
- - - - -
1f7662b1 by Fatih Uzunoglu at 2023-10-01T16:52:34+00:00
qml: hide shadow in MusicAlbumsGridExpandDelegate when image is not ready
- - - - -
d5ad9d6a by Fatih Uzunoglu at 2023-10-01T16:52:34+00:00
qml: put ArtworkInfoWidget shadow under the rectangle
- - - - -
5 changed files:
- modules/gui/qt/medialibrary/qml/MusicAlbumsGridExpandDelegate.qml
- modules/gui/qt/medialibrary/qml/VideoInfoExpandPanel.qml
- modules/gui/qt/player/qml/controlbarcontrols/ArtworkInfoWidget.qml
- modules/gui/qt/playlist/qml/PlaylistDelegate.qml
- modules/gui/qt/widgets/qml/TableColumns.qml
Changes:
=====================================
modules/gui/qt/medialibrary/qml/MusicAlbumsGridExpandDelegate.qml
=====================================
@@ -129,6 +129,7 @@ FocusScope {
Widgets.ListCoverShadow {
anchors.fill: parent
+ visible: (parent.status === RoundImage.Ready)
}
}
}
=====================================
modules/gui/qt/medialibrary/qml/VideoInfoExpandPanel.qml
=====================================
@@ -116,10 +116,12 @@ FocusScope {
anchors.fill: parent
source: model.thumbnail || VLCStyle.noArtVideoCover
radius: VLCStyle.gridCover_radius
- }
- Widgets.ListCoverShadow {
- anchors.fill: expand_cover_id
+ Widgets.ListCoverShadow {
+ anchors.fill: parent
+ z: -1
+ visible: (parent.status === RoundImage.Ready)
+ }
}
}
=====================================
modules/gui/qt/player/qml/controlbarcontrols/ArtworkInfoWidget.qml
=====================================
@@ -114,7 +114,10 @@ AbstractButton {
color: theme.bg.primary
Widgets.DoubleShadow {
- anchors.fill: parent
+ anchors.centerIn: cover
+ width: cover.paintedWidth
+ height: cover.paintedHeight
+ z: -1
primaryBlurRadius: VLCStyle.dp(3, VLCStyle.scale)
primaryVerticalOffset: VLCStyle.dp(1, VLCStyle.scale)
=====================================
modules/gui/qt/playlist/qml/PlaylistDelegate.qml
=====================================
@@ -186,6 +186,7 @@ T.ItemDelegate {
anchors.centerIn: parent
width: parent.paintedWidth
height: parent.paintedHeight
+ visible: (artwork.status === Image.Ready)
z: -1
=====================================
modules/gui/qt/widgets/qml/TableColumns.qml
=====================================
@@ -96,55 +96,52 @@ Item {
anchors.fill: parent
spacing: VLCStyle.margin_normal
- Item {
+ Widgets.MediaCover {
+ id: cover
+
Layout.preferredHeight: root.titleCover_height
Layout.preferredWidth: root.titleCover_width
- ListCoverShadow {
- anchors.fill: cover
+ source: {
+ let cover = null
+ if (!!titleDel.rowModel) {
+ cover = titleDel.rowModel[root.criteriaCover]
+ }
+ return cover || ""
}
- Widgets.MediaCover {
- id: cover
+ fallbackImageSource: titleDel.model.placeHolder || VLCStyle.noArtAlbumCover
- anchors.fill: parent
-
- source: {
- let cover = null
- if (!!titleDel.rowModel) {
- cover = titleDel.rowModel[root.criteriaCover]
+ playCoverVisible: (titleDel.currentlyFocused || titleDel.containsMouse)
+ playIconSize: VLCStyle.play_cover_small
+ onPlayIconClicked: {
+ MediaLib.addAndPlay(titleDel.rowModel.id)
+ History.push(["player"])
+ }
+ radius: root.titleCover_radius
+ color: titleDel.colorContext.bg.secondary
+
+ imageOverlay: Item {
+ width: cover.width
+ height: cover.height
+
+ Widgets.VideoQualityLabels {
+ anchors {
+ top: parent.top
+ right: parent.right
+ topMargin: VLCStyle.margin_xxsmall
+ leftMargin: VLCStyle.margin_xxsmall
+ rightMargin: VLCStyle.margin_xxsmall
}
- return cover || ""
- }
- fallbackImageSource: titleDel.model.placeHolder || VLCStyle.noArtAlbumCover
-
- playCoverVisible: (titleDel.currentlyFocused || titleDel.containsMouse)
- playIconSize: VLCStyle.play_cover_small
- onPlayIconClicked: {
- MediaLib.addAndPlay(titleDel.rowModel.id)
- History.push(["player"])
- }
- radius: root.titleCover_radius
- color: titleDel.colorContext.bg.secondary
-
- imageOverlay: Item {
- width: cover.width
- height: cover.height
-
- Widgets.VideoQualityLabels {
- anchors {
- top: parent.top
- right: parent.right
- topMargin: VLCStyle.margin_xxsmall
- leftMargin: VLCStyle.margin_xxsmall
- rightMargin: VLCStyle.margin_xxsmall
- }
-
- labels: root.titlecoverLabels(titleDel.rowModel)
- }
+ labels: root.titlecoverLabels(titleDel.rowModel)
}
}
+
+ ListCoverShadow {
+ anchors.fill: parent
+ z: -1
+ }
}
Column {
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/2986590d3a1e0291da55793f4f687a030451fe16...d5ad9d6a5380959451762da1492f4b8d63d6ea79
--
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/2986590d3a1e0291da55793f4f687a030451fe16...d5ad9d6a5380959451762da1492f4b8d63d6ea79
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance
More information about the vlc-commits
mailing list