[vlc-commits] [Git][videolan/vlc][master] 4 commits: qml: add constant for table header text height

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
13db6710 by Prince Gupta at 2023-09-11T11:50:04+00:00
qml: add constant for table header text height

- - - - -
494c8389 by Prince Gupta at 2023-09-11T11:50:04+00:00
qml: use constant for table header text height

- - - - -
a681db24 by Prince Gupta at 2023-09-11T11:50:04+00:00
qml: fix section text vertical alignment

- - - - -
99b4201a by Prince Gupta at 2023-09-11T11:50:04+00:00
qml: center align cover header

- - - - -


3 changed files:

- modules/gui/qt/network/qml/BrowseDeviceView.qml
- modules/gui/qt/style/VLCStyle.qml
- modules/gui/qt/widgets/qml/KeyNavigableTableView.qml


Changes:

=====================================
modules/gui/qt/network/qml/BrowseDeviceView.qml
=====================================
@@ -348,6 +348,8 @@ FocusScope {
                 Widgets.IconLabel {
                     text: VLCIcons.album_cover
 
+                    height: VLCStyle.listAlbumCover_height
+                    width: VLCStyle.listAlbumCover_width
                     horizontalAlignment: Text.AlignHCenter
                     verticalAlignment: Text.AlignVCenter
                     font.pixelSize: VLCStyle.icon_tableHeader


=====================================
modules/gui/qt/style/VLCStyle.qml
=====================================
@@ -216,6 +216,8 @@ QtObject {
 
     readonly property int table_cover_border: dp(2, scale)
 
+    readonly property int tableHeaderText_height: fontHeight_normal
+
     readonly property int artistBanner_height: dp(200, scale)
 
     readonly property int playlistDelegate_verticalPadding: dp(6, scale)


=====================================
modules/gui/qt/widgets/qml/KeyNavigableTableView.qml
=====================================
@@ -264,17 +264,15 @@ FocusScope {
             onHeightChanged: if (root.contentY < 0) root.positionViewAtBeginning()
 
             Widgets.ListLabel {
-                height: row.height
-
                 // NOTE: We want the section label to be slightly shifted to the left.
                 x: row.x - VLCStyle.margin_small
-                y: row.y
+                y: row.y + root.headerTopPadding
 
-                topPadding: root.headerTopPadding
+                height: VLCStyle.tableHeaderText_height
+                verticalAlignment: Text.AlignVCenter
 
                 text: view.currentSection
                 color: view.colorContext.accent
-                verticalAlignment: Text.AlignTop
                 visible: view.headerPositioning === ListView.OverlayHeader
                          && text !== ""
                          && view.contentY > (row.height - col.height - row.topPadding)
@@ -310,7 +308,7 @@ FocusScope {
                         model: sortModel
                         MouseArea {
 
-                            height: VLCStyle.dp(20, VLCStyle.scale)
+                            height: VLCStyle.tableHeaderText_height
                             width: VLCStyle.colWidth(modelData.size) || 1
 
                             Accessible.role: Accessible.ColumnHeader



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/50b7de7dea60f0789be1c44b3621f084de2adeef...99b4201a3c976fa2c6602f447d1902b59ccf502e

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/50b7de7dea60f0789be1c44b3621f084de2adeef...99b4201a3c976fa2c6602f447d1902b59ccf502e
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance