[vlc-commits] [Git][videolan/vlc][master] 47 commits: macosx: Make detail text in...

Mon Sep 25 11:01:04 UTC 2023

Felix Paul Kühne pushed to branch master at VideoLAN / VLC

Commits:
454b90db by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Make detail text in VLCLibraryCollectionViewMediaItemSupplementaryDetailView a clickable button

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
0132b819 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add property to media items describing whether detail text is potentially actionable

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
893912b6 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Deemphasize and disable media item detail buttons for items with inactionable details

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
f6a9edba by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Break the all items entry for audio groups views into separate file as it is not a real media type

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
451cab35 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Fix unimplemented protocol methods in VLCMediaLibraryDummyItem

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
e3d12ba9 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add a actionableDetailLibraryItem property to VLCMediaLibraryItemProtocol

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
abdf4189 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Separate current view mode segment calculation to separate method in VLCLibraryAudioViewController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
7c4fba60 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Fix getMediaLibrary function declaration warning

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
32b5f002 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add rowForLibraryItem method to VLCLibraryTableView protocol

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
8a05aa83 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Prevent race condition when selecting table view row in audio data source and reloading displayed collection

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
38f61ac7 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Implement actionableDetailLibraryItem for certain medai library media items

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
a31e78f7 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Emit collection changed notification in audio data source

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
927a1677 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Implement rowForLibraryItem in audio data source

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
809890c0 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add method to present a library item for a table view in library audio view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
56ee3579 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add new method to collecion view data source protocol to get index path for library item

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
dfb162e8 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Implement indexPathForLibraryItem in VLCLibraryAudioDataSource

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
9cf67071 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add method to present library item in audio library collection view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
240d90b0 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Correctly handle genres and artist presentation in grid view mode in presentItemInCollectionView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
cd5f9e89 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add public method to easily present library item in audio library

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
59270955 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add convenience method to present library item in audio library in vlclibrarywindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
9841c455 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Implement rowForLibraryItem in VLCLibraryAlbumTracksDataSource

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
af595ca7 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Implement rowForLibraryItem in VLCLibraryAudioGroupDataSource

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
99950118 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Implement rowForLibraryItem in VLCLibraryVideoTableViewDataSource

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
5a082c83 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Make returns from rowForLibraryItem methods consistent

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
4be66b81 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Use existing library item index search method for rowForLibraryItem in VLCLibraryVideoTableViewDataSource

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
d7f802e2 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Use existing index search method in VLCLibraryAudioDataSource in rowForLibraryItem

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
c850c9b7 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Implement indexPathForLibraryItem in VLCLibraryVideoCollectionViewContainerViewDataSource

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
b5eedd3b by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add presentLibraryItem convenience method to VLCLibraryVideoViewContainerView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
01453268 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add convenience method in VLCLibraryVideoCollectionViewsStackViewController to get container view for specific group

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
da5f24be by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add presentLibraryItem method to VLCLibraryVideoCollectionViewsStackViewController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
cc397dde by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Emit notification when video table view displayed collection changes

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
93179f70 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Emit notification when video collection view updates displayed collection

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
fe39c00c by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Add present library item method to VLCLibraryVideoViewController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
328269b9 by Claudio Cambra at 2023-09-25T08:22:00+00:00
Add final, top-level presentLibraryItem method in VLCLibraryWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
afa982e1 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Make detail string action button functional in VLCLibraryCollectionViewMediaItemSupplementaryDetailView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
2933c5a2 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Fix alignment of info entry fields in VLCLibraryCollectionViewMediaItemSupplementaryDetailView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
92ac1b8e by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Remove unnecessary synthesize directives in VLCLibraryCollectionViewAlbumSupplementaryDetailView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
1b73a258 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Replace album detail title text field with a button

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
2f6345de by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Disable and desaturate detail button in album supplementary detail view if no actionable detail

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
3dd74546 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Fix layouting of top elements of VLCLibraryCollectionViewAlbumSupplementaryDetailView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
4dab5720 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Make detail button in VLCLibraryCollectionViewAlbumSupplementaryDetailView functional

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
41854768 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Replace artist name text field with text button in VLCLibraryAlbumTableCelLView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
8ff5b193 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Disable and desaturate detail button in VLCLibraryAlbumTableCellView if no actionabledetail

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
17c7066f by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Make detail button in VLCLibraryAlbumTableCellView functional

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
6ce30f4f by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Ensure when presenting library item in table views we scroll to newly selected row

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
d9692b81 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Cache libraryItems.count in rowForLibraryItem implementations

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
764317d4 by Claudio Cambra at 2023-09-25T08:22:00+00:00
macosx: Use existing numberOf properties in VLCLibraryModel for all audio groups media library item

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -

30 changed files:

- extras/package/macosx/VLC.xcodeproj/project.pbxproj
- modules/gui/macosx/Makefile.am
- modules/gui/macosx/UI/VLCLibraryAlbumTableCellView.xib
- modules/gui/macosx/UI/VLCLibraryCollectionViewAlbumSupplementaryDetailView.xib
- modules/gui/macosx/UI/VLCLibraryCollectionViewMediaItemSupplementaryDetailView.xib
- modules/gui/macosx/library/VLCLibraryCollectionViewDataSource.h
- modules/gui/macosx/library/VLCLibraryCollectionViewMediaItemSupplementaryDetailView.h
- modules/gui/macosx/library/VLCLibraryCollectionViewMediaItemSupplementaryDetailView.m
- modules/gui/macosx/library/VLCLibraryDataTypes.h
- modules/gui/macosx/library/VLCLibraryDataTypes.m
- modules/gui/macosx/library/VLCLibraryTableView.h
- modules/gui/macosx/library/VLCLibraryWindow.h
- modules/gui/macosx/library/VLCLibraryWindow.m
- modules/gui/macosx/library/audio-library/VLCLibraryAlbumTableCellView.h
- modules/gui/macosx/library/audio-library/VLCLibraryAlbumTableCellView.m
- modules/gui/macosx/library/audio-library/VLCLibraryAlbumTracksDataSource.m
- + modules/gui/macosx/library/audio-library/VLCLibraryAllAudioGroupsMediaLibraryItem.h
- + modules/gui/macosx/library/audio-library/VLCLibraryAllAudioGroupsMediaLibraryItem.m
- modules/gui/macosx/library/audio-library/VLCLibraryAudioDataSource.h
- modules/gui/macosx/library/audio-library/VLCLibraryAudioDataSource.m
- modules/gui/macosx/library/audio-library/VLCLibraryAudioGroupDataSource.m
- modules/gui/macosx/library/audio-library/VLCLibraryAudioViewController.h
- modules/gui/macosx/library/audio-library/VLCLibraryAudioViewController.m
- modules/gui/macosx/library/audio-library/VLCLibraryCollectionViewAlbumSupplementaryDetailView.h
- modules/gui/macosx/library/audio-library/VLCLibraryCollectionViewAlbumSupplementaryDetailView.m
- modules/gui/macosx/library/video-library/VLCLibraryVideoCollectionViewContainerView.h
- modules/gui/macosx/library/video-library/VLCLibraryVideoCollectionViewContainerView.m
- modules/gui/macosx/library/video-library/VLCLibraryVideoCollectionViewContainerViewDataSource.h
- modules/gui/macosx/library/video-library/VLCLibraryVideoCollectionViewContainerViewDataSource.m
- modules/gui/macosx/library/video-library/VLCLibraryVideoCollectionViewsStackViewController.h

The diff was not included because it is too large.

View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/eb6a357774254e889afc1e6da903a5c00efe7925...764317d421e57469977c1d40147b481344b0bac3

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/eb6a357774254e889afc1e6da903a5c00efe7925...764317d421e57469977c1d40147b481344b0bac3
You're receiving this email because of your account on code.videolan.org.

VideoLAN code repository instance