[vlc-commits] [Git][videolan/vlc][master] qt: servicesdiscoverymodel: add missing override

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
cb260ac1 by Alexandre Janniaux at 2024-08-05T16:35:31+00:00
qt: servicesdiscoverymodel: add missing override

Commit 2212ef872ee0a44d1ddd93d21da42a088a9c6499 added getSortFunction as
a virtual pure function, but the class was not updated to override it.

Fixes the following warning:

    ../modules/gui/qt/network/servicesdiscoverymodel.cpp:141:50: warning: 'getSortFunction' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
      141 |     LocalListCacheLoader<SDItemPtr>::ItemCompare getSortFunction() const
          |                                                  ^
    ../modules/gui/qt/util/locallistbasemodel.hpp:39:59: note: overridden virtual function is here
       39 |     virtual typename LocalListCacheLoader<T>::ItemCompare getSortFunction() const = 0;
          |                                                           ^

- - - - -


1 changed file:

- modules/gui/qt/network/servicesdiscoverymodel.cpp


Changes:

=====================================
modules/gui/qt/network/servicesdiscoverymodel.cpp
=====================================
@@ -138,7 +138,7 @@ public:
 public: //BaseModelPrivateT implementation
     bool initializeModel() override;
 
-    LocalListCacheLoader<SDItemPtr>::ItemCompare getSortFunction() const
+    LocalListCacheLoader<SDItemPtr>::ItemCompare getSortFunction() const override
     {
         if (m_sortOrder == Qt::SortOrder::DescendingOrder)
             return [](const SDItemPtr& a, const SDItemPtr& b){



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/cb260ac1bb3050c569f9d57cc4950505c1133ab5

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/cb260ac1bb3050c569f9d57cc4950505c1133ab5
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance