[vlc-commits] [Git][videolan/vlc][master] 2 commits: qml: fix table header alignment in browse home view

Steve Lhomme (@robUx4) gitlab at videolan.org
Sat Aug 10 05:59:37 UTC 2024



Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
d70ddabb by Prince Gupta at 2024-08-10T05:45:39+00:00
qml: fix table header alignment in browse home view

- - - - -
afa6e6c2 by Prince Gupta at 2024-08-10T05:45:39+00:00
qml: fix table header alignment in Browse Tree views

- - - - -


2 changed files:

- modules/gui/qt/network/qml/BrowseDeviceView.qml
- modules/gui/qt/network/qml/BrowseTreeDisplay.qml


Changes:

=====================================
modules/gui/qt/network/qml/BrowseDeviceView.qml
=====================================
@@ -248,7 +248,7 @@ FocusScope {
 
                     text: qsTr("Name"),
 
-                    headerDelegate: artworkHeader,
+                    headerDelegate: tableColumns.titleHeaderDelegate,
                     colDelegate: artworkColumn
                 })
             }]
@@ -263,7 +263,7 @@ FocusScope {
 
                     isSortable: false,
 
-                    headerDelegate: artworkHeader,
+                    headerDelegate: tableColumns.titleHeaderDelegate,
                     colDelegate: artworkColumn
                 }
             }, {
@@ -309,25 +309,13 @@ FocusScope {
 
             onItemDoubleClicked: (index, model) => root.onDoubleClicked(model, index)
 
-            Component {
-                id: artworkHeader
-
-                Widgets.TableHeaderDelegate {
-                    Widgets.IconLabel {
-
-                        height: VLCStyle.listAlbumCover_height
-                        width: VLCStyle.listAlbumCover_width
-                        anchors.centerIn: parent
+            Widgets.TableColumns {
+                id: tableColumns
 
-                        horizontalAlignment: Text.AlignHCenter
-                        verticalAlignment: Text.AlignVCenter
-                        font.pixelSize: VLCStyle.icon_tableHeader
+                titleCover_width: VLCStyle.listAlbumCover_width
+                titleCover_height: VLCStyle.listAlbumCover_height
 
-                        text: VLCIcons.album_cover
-
-                        color: parent.colorContext.fg.secondary
-                    }
-                }
+                showTitleText: false
             }
 
             Component {


=====================================
modules/gui/qt/network/qml/BrowseTreeDisplay.qml
=====================================
@@ -209,21 +209,6 @@ MainViewLoader {
         MainTableView {
             id: tableView
 
-            property Component thumbnailHeader: Widgets.TableHeaderDelegate {
-                Widgets.IconLabel {
-                    height: VLCStyle.listAlbumCover_height
-                    width: VLCStyle.listAlbumCover_width
-
-                    anchors.centerIn: parent
-
-                    horizontalAlignment: Text.AlignHCenter
-                    verticalAlignment: Text.AlignVCenter
-                    font.pixelSize: VLCStyle.icon_tableHeader
-                    text: VLCIcons.album_cover
-                    color: parent.colorContext.fg.secondary
-                }
-            }
-
             property Component thumbnailColumn: NetworkThumbnailItem {
                 onPlayClicked: index => playAt(index)
             }
@@ -240,7 +225,7 @@ MainViewLoader {
 
                     text: qsTr("Name"),
 
-                    headerDelegate: thumbnailHeader,
+                    headerDelegate: tableColumns.titleHeaderDelegate,
                     colDelegate: thumbnailColumn
                 })
             }]
@@ -255,7 +240,7 @@ MainViewLoader {
 
                     isSortable: false,
 
-                    headerDelegate: thumbnailHeader,
+                    headerDelegate: tableColumns.titleHeaderDelegate,
                     colDelegate: thumbnailColumn
                 }
             }, {
@@ -331,6 +316,11 @@ MainViewLoader {
 
             Widgets.TableColumns {
                 id: tableColumns
+
+                titleCover_width: VLCStyle.listAlbumCover_width
+                titleCover_height: VLCStyle.listAlbumCover_height
+
+                showTitleText: false
             }
         }
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/4c595eebe8144d3d4537e72d98e2d1f0e5e028aa...afa6e6c244252d12e66b792f82d4fb60d5f13439

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/4c595eebe8144d3d4537e72d98e2d1f0e5e028aa...afa6e6c244252d12e66b792f82d4fb60d5f13439
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list