[vlc-commits] [Git][videolan/vlc][master] 4 commits: Revert "contrib: gcrypt: disable asm for macOS aarch64 for now"

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
5885e53a by Steve Lhomme at 2024-08-13T11:15:52+00:00
Revert "contrib: gcrypt: disable asm for macOS aarch64 for now"

This reverts commit 8edd1a300a429efb6fa518c600f62db532dba258.

It seems to build properly. Modern should support arm64 properly.

We also build ASM for iOS/tvOS/xrOS since HAVE_BSD is no longer
set for these (4bfdaf555b842d4426daf7e2f048eaaaf1784f6b).

- - - - -
23feca2c by Steve Lhomme at 2024-08-13T11:15:52+00:00
contrib: gcrypt: remove aesni-support disabling

It's automatically detecting if SSE3/AVX/AVX2 is supported
byt the compiler to use these.

It was originally added in 7c98e07cc07295b40f034a31c0fa35ed001434a0.

- - - - -
162ddaf3 by Steve Lhomme at 2024-08-13T11:15:52+00:00
contrib: gcrypt: enable ac_cv_sys_symbol_underscore on all Darwin platforms

Linking fails on arm64 if it's not set. It seems more coherent that way.

- - - - -
7ef9b254 by Steve Lhomme at 2024-08-13T11:15:52+00:00
contrib: gcrypt: enable hardware acceleration on BSD

There's no reason it should be disabled. It was picked from the iOS fallback before.

- - - - -


1 changed file:

- contrib/src/gcrypt/rules.mak


Changes:

=====================================
contrib/src/gcrypt/rules.mak
=====================================
@@ -48,19 +48,8 @@ GCRYPT_CONF += --disable-asm --disable-padlock-support
 endif
 endif
 ifdef HAVE_DARWIN_OS
-ifeq ($(ARCH),x86_64)
 GCRYPT_CONF += ac_cv_sys_symbol_underscore=yes
 endif
-endif
-ifdef HAVE_MACOSX
-GCRYPT_CONF += --disable-aesni-support
-ifeq ($(ARCH),aarch64)
-GCRYPT_CONF += --disable-asm --disable-arm-crypto-support
-endif
-endif
-ifdef HAVE_BSD
-GCRYPT_CONF += --disable-asm --disable-aesni-support
-endif
 ifdef HAVE_ANDROID
 ifeq ($(ANDROID_ABI), x86)
 GCRYPT_CONF += ac_cv_sys_symbol_underscore=no



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e04bdb364062a46def18a7167d58e9baba0b5592...7ef9b254d2b9f0daae572998e2d127c8a31df7a8

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e04bdb364062a46def18a7167d58e9baba0b5592...7ef9b254d2b9f0daae572998e2d127c8a31df7a8
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance