[vlc-commits] [Git][videolan/vlc][master] 2 commits: demux: mkv: fix potential return type warning

Steve Lhomme (@robUx4) gitlab at videolan.org
Tue Dec 3 09:49:44 UTC 2024



Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
73bce007 by Steve Lhomme at 2024-12-03T08:19:31+00:00
demux: mkv: fix potential return type warning

We don't want a default case in this handler. But gcc 14 complains:

> control reaches end of non-void function

- - - - -
a5732065 by Steve Lhomme at 2024-12-03T08:19:31+00:00
qt: handle missing update status

This case should never happen.

- - - - -


2 changed files:

- modules/demux/mkv/chapter_command_dvd.cpp
- modules/gui/qt/dialogs/help/help.cpp


Changes:

=====================================
modules/demux/mkv/chapter_command_dvd.cpp
=====================================
@@ -610,6 +610,7 @@ bool dvd_command_interpretor_c::HandleKeyEvent( NavivationKey key )
     case POPUP:
         return false;
     }
+    vlc_assert_unreachable();
 }
 
 void dvd_command_interpretor_c::HandleMousePressed( unsigned x, unsigned y )


=====================================
modules/gui/qt/dialogs/help/help.cpp
=====================================
@@ -425,6 +425,9 @@ void UpdateDialog::updateUI( )
             qtr( "Checking for updates..." ) );
         break;
     }
+    case UpdateModel::Unchecked:
+        // do nothing
+        break;
     }
 }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e65b2754012af5b419c9078ca3a7a63a8f033676...a5732065a21f967f5aae1c9b8d3b5eb7bbc201b3

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/e65b2754012af5b419c9078ca3a7a63a8f033676...a5732065a21f967f5aae1c9b8d3b5eb7bbc201b3
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list