[vlc-commits] [Git][videolan/vlc][master] qml: do not use independent window for ToolTipExt on wayland

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
acea10bf by Fatih Uzunoglu at 2024-12-05T09:12:21+00:00
qml: do not use independent window for ToolTipExt on wayland

Although it seems to work, it is not reliable with Wayland.
With KWin Wayland compositor I often get the error:

qt.qpa.wayland: eglSwapBuffers failed with 0x300d, surface: 0x7be3c8512b70

I suspect that this occurs when the window is shown/hidden
before the fade animation ends. Since we don't control the
animation, and we have to support fast visibility changes
mainly (but not limited to) due to the pointing tool tip
that is used within the seek bar, we should go back to the
old approach with Wayland for the moment.

On Windows and X11, it so far has worked well for me.

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/ToolTipExt.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/ToolTipExt.qml
=====================================
@@ -41,7 +41,8 @@ T.ToolTip {
 
     Component.onCompleted: {
         if (typeof control.popupType === "number")
-            control.popupType = 1 // Popup.Window
+            if (Qt.platform.pluginName !== "wayland") // FIXME: Qt 6.8.0 Wayland is not reliable
+                control.popupType = 1 // Popup.Window
     }
 
     // NOTE: The tool tip often moves around, particularly noticable



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/acea10bf045d64109c5b13341cb63e7759cafac8

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/acea10bf045d64109c5b13341cb63e7759cafac8
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance