[vlc-commits] [Git][videolan/vlc][master] 2 commits: qml: if title is empty use "Unknown Title" in playlist delegate

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
a470d9f7 by Fatih Uzunoglu at 2024-12-14T15:59:01+00:00
qml: if title is empty use "Unknown Title" in playlist delegate

Currently, if title is empty:

- In ArtworkInfoWidget, length gets centered. We probably don't
want to show "Unknown X" there to not occupy space, centering
seems to be a good compromise.
- In PlaylistDelegate, if artist is empty it prints "Unknown
Artist", and the field for the title remains empty. This is not
coherent, and it does not look good.

- - - - -
7deba9d7 by Fatih Uzunoglu at 2024-12-14T15:59:01+00:00
qml: if artist is empty do not use "Unknown Artist" in PlaylistDelegate

- - - - -


1 changed file:

- modules/gui/qt/playlist/qml/PlaylistDelegate.qml


Changes:

=====================================
modules/gui/qt/playlist/qml/PlaylistDelegate.qml
=====================================
@@ -208,7 +208,7 @@ T.Control {
                 Layout.fillWidth: true
 
                 font.weight: model.isCurrent ? Font.Bold : Font.DemiBold
-                text: model.title
+                text: model.title || qsTr("Unknown Title")
                 color: theme.fg.primary
             }
 
@@ -217,7 +217,7 @@ T.Control {
 
                 Layout.fillWidth: true
 
-                text: model.artist || qsTr("Unknown Artist")
+                text: model.artist
                 color: theme.fg.primary
             }
         }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c94ab5e31b0a75ef853db40b6644a6115ad63692...7deba9d749bd2edc7c4db965ab5f9274a5b1923c

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/c94ab5e31b0a75ef853db40b6644a6115ad63692...7deba9d749bd2edc7c4db965ab5f9274a5b1923c
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance