[vlc-commits] [Git][videolan/vlc][master] qml: do not probe sibling visibility in `RoundImage.qml`

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
0c2e58d4 by Fatih Uzunoglu at 2024-12-15T07:48:59+00:00
qml: do not probe sibling visibility in `RoundImage.qml`

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/RoundImage.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/RoundImage.qml
=====================================
@@ -50,7 +50,9 @@ Item {
 
         anchors.fill: parent
 
-        visible: (root.radius > 0.0) && (GraphicsInfo.shaderType === GraphicsInfo.RhiShader)
+        visible: readyForVisibility
+
+        readonly property bool readyForVisibility: (root.radius > 0.0) && (GraphicsInfo.shaderType === GraphicsInfo.RhiShader)
 
         supportsAtlasTextures: true
 
@@ -84,7 +86,12 @@ Item {
 
         anchors.fill: parent
 
-        visible: !shaderEffect.visible
+        // Image should not be visible when there is rounding and RHI shader is supported.
+        // This is simply when the shader effect is invisible. However, Do not use `!shaderEffect.visible`,
+        // because the root item may be invisible (`grabToImage()` call on an invisible
+        // item case). In that case, shader effect would report invisible although it
+        // would appear in the grabbed image.
+        visible: !shaderEffect.readyForVisibility
 
         fillMode: Image.PreserveAspectCrop
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0c2e58d40c2946e0a3d81d033c2c8ce564fd44c1

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/0c2e58d40c2946e0a3d81d033c2c8ce564fd44c1
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance