[vlc-commits] [Git][videolan/vlc][master] qml: hide source item in DynamicShadow only if it is actually visible

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
681ad715 by Fatih Uzunoglu at 2024-12-16T10:35:03+00:00
qml: hide source item in DynamicShadow only if it is actually visible

MultiEffect based DynamicShadow hides the source item because it
renders the source item itself again anyway. However, it does not
set itself invisible when it can not be used (software renderer).

The binding that makes the source item invisible checks if the effect
is visible. Here, we can simply bind the visibility to shader type
where the graphics backend needs to support RHI shader for the effect
to work. This is currently OpenGL, Vulkan, Metal, DirectX; so no
support for Software or OpenVG scene graph adaptations which are
not targeted by Qt RHI for obvious reasons.

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/DynamicShadow.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/DynamicShadow.qml
=====================================
@@ -29,6 +29,8 @@ MultiEffect {
 
     paddingRect: Qt.rect(xOffset, yOffset, 0, 0)
 
+    visible: (GraphicsInfo.shaderType === GraphicsInfo.RhiShader)
+
     property alias sourceItem: effect.source
 
     property alias xOffset: effect.shadowHorizontalOffset



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/681ad715ace72ab4735432955f502b4d0ef2e847

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/681ad715ace72ab4735432955f502b4d0ef2e847
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance