[vlc-commits] [Git][videolan/vlc][master] sout: rtp: surface error if xiph_config fails

[Tristan Matthews (@tmatth)]

Tristan Matthews pushed to branch master at VideoLAN / VLC


Commits:
4f2e94c3 by Tristan Matthews at 2024-12-17T16:36:34+00:00
sout: rtp: surface error if xiph_config fails

Rationale: without the associated config, a vorbis or theora
RTP stream is likely not recoverable downstream.

- - - - -


1 changed file:

- modules/stream_out/rtp.c


Changes:

=====================================
modules/stream_out/rtp.c
=====================================
@@ -1224,8 +1224,13 @@ static int Send( sout_stream_t *p_stream, void *_id, block_t *p_buffer )
             if (!strcmp(id->rtp_fmt.ptname, "vorbis") ||
                 !strcmp(id->rtp_fmt.ptname, "theora"))
             {
-                if (rtp_packetize_xiph_config(id, id->rtp_fmt.fmtp, p_buffer->i_pts))
-                    break;
+                int ret = rtp_packetize_xiph_config(id, id->rtp_fmt.fmtp, p_buffer->i_pts);
+                if (ret)
+                {
+                    /* Since we're returning early, this module owns the remaining blocks */
+                    block_ChainRelease(p_buffer);
+                    return ret;
+                }
             }
         }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/4f2e94c3c82426bba9a8a07cc022849fb30ccc03

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/4f2e94c3c82426bba9a8a07cc022849fb30ccc03
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance