[vlc-commits] [Git][videolan/vlc][master] win32: Prevent VLC from registering as the default player for MIDI files

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
dd4f9152 by Vikram Kangotra at 2024-12-28T09:18:11+00:00
win32: Prevent VLC from registering as the default player for MIDI files

This commit resolves an issue where the installation of VLC on Windows
unintentionally designated it as the default application for MIDI files.
Given that Windows supports MIDI playback natively through Windows Media
Player and that VLC requires a SoundFont for proper MIDI playback, this
change ensures that VLC does not disrupt the default MIDI file associations,
maintaining the expected user experience.

Fixes: #27464

- - - - -


1 changed file:

- extras/package/win32/NSIS/helpers/extensions.nsh


Changes:

=====================================
extras/package/win32/NSIS/helpers/extensions.nsh
=====================================
@@ -155,7 +155,6 @@ FunctionEnd
   !insertmacro ${_action} Audio ".it"
   !insertmacro ${_action} Audio ".m4a"
   !insertmacro ${_action} Audio ".m4p"
-  !insertmacro ${_action} Audio ".mid"
   !insertmacro ${_action} Audio ".mka"
   !insertmacro ${_action} Audio ".mlp"
   !insertmacro ${_action} Audio ".mod"
@@ -272,6 +271,7 @@ FunctionEnd
 
 !macro MacroUnassociatedExtensions _action
   !insertmacro ${_action} Other ".iso"
+  !insertmacro ${_action} Audio ".mid"
   !insertmacro ${_action} Other ".zip"
   !insertmacro ${_action} Other ".rar"
 !macroend



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/dd4f9152118af3667f3befa568f20ed6e4cf4fb3

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/dd4f9152118af3667f3befa568f20ed6e4cf4fb3
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance