[vlc-commits] [Git][videolan/vlc][master] codec: Makefile.am: rename Videotoolbox plugin

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
3e02a857 by Alexandre Janniaux at 2024-02-22T22:43:42+00:00
codec: Makefile.am: rename Videotoolbox plugin

Because of how the MODULE_NAME macro is injected into automake from
AM_CPPFLAGS and how automake will compile files that have no specific
compilation flags from a given target (ie. no _CPPFLAGS override or
_CFLAGS/_CXXFLAGS/_OBJCFLAGS override), the videotoolbox module was
named "decoder" (as the first compiled file) which is highly confusing
to read in the log.

Forcing the default CPPFLAGS will ensure we correctly get videotoolbox
as the MODULE_NAME.

- - - - -


1 changed file:

- modules/codec/Makefile.am


Changes:

=====================================
modules/codec/Makefile.am
=====================================
@@ -356,6 +356,7 @@ libvideotoolbox_plugin_la_SOURCES = codec/videotoolbox/decoder.c \
                                     codec/videotoolbox/dpb.h \
                                     codec/videotoolbox/pacer.c \
                                     codec/videotoolbox/pacer.h
+libvideotoolbox_plugin_la_CPPFLAGS = $(AM_CPPFLAGS) # Trigger MODULE_NAME declaration
 libvideotoolbox_plugin_la_LIBADD = libchroma_copy.la libvlc_hxxxhelper.la libvlc_vtutils.la
 libvideotoolbox_plugin_la_LDFLAGS = $(AM_LDFLAGS) -Wl,-framework,CoreFoundation -Wl,-framework,VideoToolbox -Wl,-framework,CoreMedia -Wl,-framework,CoreVideo -Wl,-framework,Metal
 if HAVE_DARWIN



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/3e02a85781c2aec34c6bfa65df2463a614753642

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/3e02a85781c2aec34c6bfa65df2463a614753642
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance