[vlc-commits] [Git][videolan/vlc][master] 2 commits: contrib: gcrypt: set ac_cv_sys_symbol_underscore on all x86_64 Darwin targets

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
b84592f3 by Steve Lhomme at 2024-07-26T10:16:02+00:00
contrib: gcrypt: set ac_cv_sys_symbol_underscore on all x86_64 Darwin targets

This should fix link issues like:
Undefined symbols for architecture x86_64:
  "__gcry_mpih_add_n", referenced from:
      __gcry_mpi_add in libgcrypt.a(mpi-add.o)
      _ec_addm_25519 in libgcrypt.a(ec.o)
      _ec_subm_25519 in libgcrypt.a(ec.o)
      _ec_mulm_25519 in libgcrypt.a(ec.o)
      _ec_addm_448 in libgcrypt.a(ec.o)
      _ec_subm_448 in libgcrypt.a(ec.o)
      _ec_mulm_448 in libgcrypt.a(ec.o)
      ...
     (maybe you meant: __gcry_mpih_add_n_cond)

- - - - -
95cbfa9e by Steve Lhomme at 2024-07-26T10:16:02+00:00
contrib: gcrypt: remove iOS specific -fheinous-gnu-extensions

It's asm related to noop [1] but there doesn't seem to be any left in the
asm code.

- - - - -


1 changed file:

- contrib/src/gcrypt/rules.mak


Changes:

=====================================
contrib/src/gcrypt/rules.mak
=====================================
@@ -43,17 +43,16 @@ ifeq ($(ARCH),x86_64)
 GCRYPT_CONF += --disable-asm --disable-padlock-support
 endif
 endif
-ifdef HAVE_IOS
-GCRYPT_CONF += CFLAGS="$(CFLAGS) -fheinous-gnu-extensions"
+ifdef HAVE_DARWIN_OS
+ifeq ($(ARCH),x86_64)
+GCRYPT_CONF += ac_cv_sys_symbol_underscore=yes
+endif
 endif
 ifdef HAVE_MACOSX
 GCRYPT_CONF += --disable-aesni-support
 ifeq ($(ARCH),aarch64)
 GCRYPT_CONF += --disable-asm --disable-arm-crypto-support
 endif
-ifeq ($(ARCH), x86_64)
-GCRYPT_CONF += ac_cv_sys_symbol_underscore=yes
-endif
 endif
 ifdef HAVE_BSD
 GCRYPT_CONF += --disable-asm --disable-aesni-support



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/f993009c6e190eb129591d93e21f830e12d11a1e...95cbfa9e2a3432889de61397e9e99a10fa5d96bc

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/f993009c6e190eb129591d93e21f830e12d11a1e...95cbfa9e2a3432889de61397e9e99a10fa5d96bc
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance