[vlc-commits] [Git][videolan/vlc][master] macosx: Fix warning about incompatible pointer types caused by non-NSString artwork URL (is NSURL)

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
67a2dd14 by Claudio Cambra at 2024-07-30T08:32:35+00:00
macosx: Fix warning about incompatible pointer types caused by non-NSString artwork URL (is NSURL)

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


1 changed file:

- modules/gui/macosx/library/VLCInputItem.m


Changes:

=====================================
modules/gui/macosx/library/VLCInputItem.m
=====================================
@@ -745,14 +745,15 @@ NSString * const value_##prop =
     PERFORM_ACTION_PER_INPUTITEM_PROP(CREATE_DIFFER_BOOL);
     PERFORM_ACTION_PER_INPUTITEM_NSSTRING_PROP(CREATE_PROP_VAR);
     // Since artworkURL is a URL, we have to handle it differently
-    NSURL * const firstItem_artworkURL = firstInputItem.artworkURL;
+    NSString * const firstItem_artworkURL = firstInputItem.artworkURL.absoluteString;
 
     // Skip first item
     for (uint i = 1; i < inputItems.count; ++i) {
         VLCInputItem * const inputItem = inputItems[i];
 
         PERFORM_ACTION_PER_INPUTITEM_NSSTRING_PROP(UPDATE_IF_DIFFERING_BOOL);
-        differing_artworkURL = differing_artworkURL || ![inputItem.artworkURL.absoluteString isEqualToString:firstItem_artworkURL.absoluteString];
+        NSString * const inputItem_artworkURL = inputItem.artworkURL.absoluteString;
+        differing_artworkURL |= ![inputItem_artworkURL isEqualToString:firstItem_artworkURL];
     }
 
     PERFORM_ACTION_PER_INPUTITEM_PROP(ADD_PROP_TO_DICT);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/67a2dd14bf77b2c7aac1ed4f39818c9081abae85

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/67a2dd14bf77b2c7aac1ed4f39818c9081abae85
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance