[vlc-commits] [Git][videolan/vlc][master] qt: detect Windows 11 22H2 properly in win32windoweffects module

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
aaba70b6 by Fatih Uzunoglu at 2024-06-01T05:05:40+00:00
qt: detect Windows 11 22H2 properly in win32windoweffects module

Windows 11 identifies as Windows 10 (NT 10),
so this comparison always yields false.

As a side note, native acrylic background
for Win32 windows only gained support with
the Windows 11 22H2 update, that's why
there is the check here.

Note that according to the general conventions
a transparent window must be frameless on
Windows. This is currently not the case,
because "frameless window don't support
areo snapping". So, it can be considered
as a known bug if native acrylic does not
work as intended. This grants a requirement
of change to use frameless window, and get
rid of the current workaround that simulates
frameless window in mainctx_win32.cpp. If
aero snapping does not work, it is Windows's
problem since we are using frameless windows
in every other platform.

- - - - -


1 changed file:

- modules/gui/qt/maininterface/win32windoweffects_module.cpp


Changes:

=====================================
modules/gui/qt/maininterface/win32windoweffects_module.cpp
=====================================
@@ -59,7 +59,7 @@ int QtWin32WindowEffectsOpen(vlc_object_t* p_this)
     assert(p_this);
 
     if (QOperatingSystemVersion::current()
-        < QOperatingSystemVersion(QOperatingSystemVersion::Windows, 11, 0, 22621))
+        < QOperatingSystemVersion(QOperatingSystemVersion::Windows, 10, 0, 22621))
         return VLC_EGENERIC;
 
     const auto obj = reinterpret_cast<WindowEffectsModule*>(p_this);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/aaba70b606ed54eb57eba7c7a66552bbd8e1e74f

-- 
This project does not include diff previews in email notifications.
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/aaba70b606ed54eb57eba7c7a66552bbd8e1e74f
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance