[vlc-commits] [Git][videolan/vlc][master] 2 commits: macosx: Fix reloadData breaking carousel item views in iCarousel

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
fb29981a by Claudio Cambra at 2024-06-02T08:00:53+00:00
macosx: Fix reloadData breaking carousel item views in iCarousel

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
009960d4 by Claudio Cambra at 2024-06-02T08:00:53+00:00
macosx: Remove autoscroll and wrapping in home view carousels

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


2 changed files:

- modules/gui/macosx/library/home-library/VLCLibraryHomeViewBaseCarouselContainerView.m
- modules/gui/macosx/views/iCarousel/iCarousel.m


Changes:

=====================================
modules/gui/macosx/library/home-library/VLCLibraryHomeViewBaseCarouselContainerView.m
=====================================
@@ -113,9 +113,6 @@
 
     [self updateCarouselViewHeight];
     [self updateCarouselOffset];
-
-    self.carouselView.autoscroll = -.05;
-    self.carouselView.reenablePostInteractAutoscrollTimeout = 3.;
 }
 
 - (void)connect
@@ -209,8 +206,6 @@
         const CGFloat desiredMultiple = desiredWidthWithSpacing / itemWidth;
         return desiredMultiple;
     }
-    case iCarouselOptionWrap:
-        return YES;
     default:
         return value;
     }


=====================================
modules/gui/macosx/views/iCarousel/iCarousel.m
=====================================
@@ -1372,6 +1372,11 @@ NSComparisonResult compareViewDepth(UIView *view1, UIView *view2, iCarousel *sel
     {
         [self scrollToItemAtIndex:0 animated:(_numberOfPlaceholders > 0)];
     }
+
+    [self loadUnloadViews];
+    [self pushAnimationState:NO];
+    [self layOutItemViews];
+    [self popAnimationState];
 }
 
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/05134504b0dd59100db6327acd2ad7b06b149cb2...009960d468e356fdb1e67b24ae9e2a4484311f59

-- 
This project does not include diff previews in email notifications.
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/05134504b0dd59100db6327acd2ad7b06b149cb2...009960d468e356fdb1e67b24ae9e2a4484311f59
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance