[vlc-commits] [Git][videolan/vlc][master] 2 commits: package/win32: move the PDB files in symbols-x.x.x when stripping

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
4ebb57f1 by Steve Lhomme at 2024-06-13T14:42:17+00:00
package/win32: move the PDB files in symbols-x.x.x when stripping

Before that they are in the debug folder.

They can be used by adding the symbols folder to Visual Studio:
> Tools > Options > Debugging > Symbols

Or Visual Studio Code:
Using the "symbolSearchPath" variable in the launch configuration
https://code.visualstudio.com/docs/cpp/cpp-debug#_additional-symbols

- - - - -
f6e5e376 by Steve Lhomme at 2024-06-13T14:42:17+00:00
CI: build LLVM Windows nightly builds with PDB files

The PDB files will be inside the -debug.7z package.

The PDB source mapping will be the '<root>/vlc' folder to '/'.

In Visual Studio you can map to your local source folder with:
> Solution > Properties > Debug Source Files > "s:/sources/vlc"

In Visual Studio Code you can map to your local source folder with the
"sourceFileMap" variable in the launch configuration
https://code.visualstudio.com/docs/cpp/launch-json-reference#_sourcefilemap:

> "sourceFileMap": { "/": "s:/sources/vlc" }

- - - - -


2 changed files:

- extras/ci/gitlab-ci.yml
- extras/package/win32/package.mak


Changes:

=====================================
extras/ci/gitlab-ci.yml
=====================================
@@ -212,7 +212,9 @@ nightly-win32-llvm:
     extends: .nightly-win-common
     image:
         name: $VLC_WIN_LLVM_MSVCRT_IMAGE
-    variables: *variables-win32
+    variables:
+        <<: *variables-win32
+        LIBVLC_EXTRA_BUILD_FLAGS: -D /
 
 nightly-win64:
     extends: .nightly-win-common
@@ -224,7 +226,9 @@ nightly-win64-llvm:
     extends: .nightly-win-common
     image:
         name: $VLC_WIN_LLVM_MSVCRT_IMAGE
-    variables: *variables-win64
+    variables:
+        <<: *variables-win64
+        LIBVLC_EXTRA_BUILD_FLAGS: -D /
 
 nightly-win64-ucrt-llvm:
     extends: .nightly-win-common
@@ -234,6 +238,7 @@ nightly-win64-ucrt-llvm:
         <<: *variables-win64
         VLCARCH: win64-ucrt
         TRIPLET: $HOST_ARCH-ucrt-w64-mingw32
+        LIBVLC_EXTRA_BUILD_FLAGS: -D /
         UWP_EXTRA_BUILD_FLAGS: -u -x -S 0x0A000006
 
 nightly-win64-arm-llvm:
@@ -244,6 +249,7 @@ nightly-win64-arm-llvm:
         <<: *variables-win64-arm
         VLCARCH: winarm64-ucrt
         TRIPLET: $HOST_ARCH-ucrt-w64-mingw32
+        LIBVLC_EXTRA_BUILD_FLAGS: -D /
         UWP_EXTRA_BUILD_FLAGS: -u -x -S 0x0A000006
         # Clang <= 15 produces incorrect unwind info for code with
         # branch protection enabled on Windows.


=====================================
extras/package/win32/package.mak
=====================================
@@ -103,6 +103,13 @@ package-win-activex: build-npapi
 
 package-win-strip: package-win-common package-win-activex
 	mkdir -p "$(win32_debugdir)"/
+if ENABLE_PDB
+	find $(win32_destdir) -type f -name '*.pdb' | while read i; \
+	do if test -n "$$i" ; then \
+	    mv "$$i" "$(win32_debugdir)/`basename $$i`"; \
+	  fi ; \
+	done
+endif
 	find $(win32_destdir) -type f \( -name '*$(LIBEXT)' -or -name '*$(EXEEXT)' \) | while read i; \
 	do if test -n "$$i" ; then \
 	    $(OBJCOPY) --only-keep-debug "$$i" "$(win32_debugdir)/`basename $$i.dbg`"; \



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/99ba59dfd81ab96d1dc52df8fafece0f94025e25...f6e5e3769f744635994f773bedfd18e7d7d92dc4

-- 
This project does not include diff previews in email notifications.
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/99ba59dfd81ab96d1dc52df8fafece0f94025e25...f6e5e3769f744635994f773bedfd18e7d7d92dc4
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance