[vlc-commits] [Git][videolan/vlc][master] qml: prevent unintentional background blending in player playqueue

[Felix Paul Kühne (@fkuehne)]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
46d9063b by Fatih Uzunoglu at 2024-06-23T12:18:42+00:00
qml: prevent unintentional background blending in player playqueue

- - - - -


2 changed files:

- modules/gui/qt/playlist/qml/PlaylistListView.qml
- modules/gui/qt/widgets/qml/FadingEdge.qml


Changes:

=====================================
modules/gui/qt/playlist/qml/PlaylistListView.qml
=====================================
@@ -263,8 +263,8 @@ T.Pane {
                 value: false
             }
 
-            fadingEdge.backgroundColor: root.background.usingAcrylic ? "transparent"
-                                                                     : (root.background?.color ?? "transparent")
+            fadingEdge.backgroundColor: (root.background && (root.background.color.a >= 1.0)) ? root.background.color
+                                                                                             : "transparent"
 
             contentWidth: width
 


=====================================
modules/gui/qt/widgets/qml/FadingEdge.qml
=====================================
@@ -26,9 +26,9 @@ Item {
     // backgroundColor is only needed for sub-pixel
     // font rendering. Or, if the background color
     // needs to be known during rendering in general.
-    // Ideally it should be fully opaque, but it is
-    // still better than not providing any color
-    // information.
+    // Ideally it should be fully opaque, otherwise
+    // the background here may blend with the actual
+    // background.
     property alias backgroundColor: backgroundRect.color
 
     property alias sourceItem: shaderEffectSource.sourceItem



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/46d9063b2eefa792f4511bce2866894a7328dec6

-- 
This project does not include diff previews in email notifications.
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/46d9063b2eefa792f4511bce2866894a7328dec6
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance