[vlc-commits] [Git][videolan/vlc][master] qml: fix color handling in table view for some qt versions

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
dee7fb6e by Prince Gupta at 2024-05-10T10:06:20+00:00
qml: fix color handling in table view for some qt versions

fixes binding assignment,
using QObject/QGadget types in Qt.binding fails
see https://bugreports.qt.io/browse/QTBUG-125095

- - - - -


2 changed files:

- modules/gui/qt/widgets/qml/TableHeaderDelegate.qml
- modules/gui/qt/widgets/qml/TableRowDelegate.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/TableHeaderDelegate.qml
=====================================
@@ -16,9 +16,12 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 import QtQuick
-import org.videolan.vlc 0.1
 
 Item {
     required property var colModel
-    required property ColorContext colorContext
+
+    // using QObject/QGadget types in Qt.binding fails
+    // so don't mark 'ColorContext' type here
+    // see https://bugreports.qt.io/browse/QTBUG-125095
+    required property var colorContext
 }


=====================================
modules/gui/qt/widgets/qml/TableRowDelegate.qml
=====================================
@@ -16,14 +16,17 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 import QtQuick
-import org.videolan.vlc 0.1
 
 Item {
     required property int index
     required property var colModel
     required property var rowModel
-    required property ColorContext colorContext
     required property bool selected
     required property bool containsMouse
     required property bool currentlyFocused
+
+    // using QObject/QGadget types in Qt.binding fails
+    // so don't mark 'ColorContext' type here
+    // see https://bugreports.qt.io/browse/QTBUG-125095
+    required property var colorContext
 }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/dee7fb6e7b762f1120a7dec46ab962e3be6ac984

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/dee7fb6e7b762f1120a7dec46ab962e3be6ac984
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance