[vlc-commits] [Git][videolan/vlc][master] videotoolbox: do not abort for NULL dropped frame

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
929aace3 by Marvin Scholz at 2024-05-17T05:51:33+00:00
videotoolbox: do not abort for NULL dropped frame

In case a frame is marked as dropped, do not abort VideoToolbox decoding
when the imageBuffer is NULL, as that is a valid case that can happen
for lossy RTP streams for example.

Fix #28420

- - - - -


1 changed file:

- modules/codec/videotoolbox/decoder.c


Changes:

=====================================
modules/codec/videotoolbox/decoder.c
=====================================
@@ -2125,10 +2125,16 @@ static void DecoderCallback(void *decompressionOutputRefCon,
             p_sys->vtsession_status = vtsession_status;
         goto end;
     }
-    if (unlikely(!imageBuffer))
+
+    if (!imageBuffer)
     {
-        msg_Err(p_dec, "critical: null imageBuffer with a valid status");
-        p_sys->vtsession_status = VTSESSION_STATUS_ABORT;
+        if (unlikely((infoFlags & kVTDecodeInfo_FrameDropped) != kVTDecodeInfo_FrameDropped))
+        {
+            msg_Err(p_dec, "critical: null imageBuffer for a non-dropped frame with valid status");
+            p_sys->vtsession_status = VTSESSION_STATUS_ABORT;
+        } else {
+            msg_Dbg(p_dec, "decoder dropped frame");
+        }
         goto end;
     }
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/929aace30d6956dc4823959352ba51e3dc7a8692

-- 
This project does not include diff previews in email notifications.
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/929aace30d6956dc4823959352ba51e3dc7a8692
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance