[vlc-commits] [Git][videolan/vlc][master] Revert "configure: generate an error in extra checks when return type is bogus"

[Rémi Denis-Courmont (@Courmisch)]

Rémi Denis-Courmont pushed to branch master at VideoLAN / VLC


Commits:
239eafa8 by Rémi Denis-Courmont at 2024-05-30T18:26:05+03:00
Revert "configure: generate an error in extra checks when return type is bogus"

This reverts commit 4cd7d490402b1e733f41a5b1b593077a3bc39ab1.

This warning can occur in callbacks that never return. Some functions cannot
have a return statement because that would cause dead code warnings, while
they also cannot return void because the callback prototype is externally
mandated. Ideally the compiler would notice that the function does not
return, and sometimes it does, but evidently we cannot rely on that, so
we have to revert this warning back to a warning, not an error.

Fixes #28650.

- - - - -


1 changed file:

- configure.ac


Changes:

=====================================
configure.ac
=====================================
@@ -1189,9 +1189,9 @@ AC_ARG_ENABLE([extra_checks],
                     [Turn some warnings into compilation error (default disabled)]),,
                     [enable_extra_checks="no"])
 AS_IF([test "${enable_extra_checks}" = "yes"], [
-    AX_APPEND_COMPILE_FLAGS([-Werror=missing-field-initializers -Werror=format -Werror=incompatible-pointer-types -Werror=restrict -Werror=int-conversion -Werror=return-type -Werror=implicit-int -Werror=return-mismatch -Werror=declaration-missing-parameter-type], [CFLAGS])
+    AX_APPEND_COMPILE_FLAGS([-Werror=missing-field-initializers -Werror=format -Werror=incompatible-pointer-types -Werror=restrict -Werror=int-conversion -Werror=implicit-int -Werror=return-mismatch -Werror=declaration-missing-parameter-type], [CFLAGS])
     AC_LANG_PUSH(C++)
-    AX_APPEND_COMPILE_FLAGS([-Werror=missing-field-initializers -Werror=format -Werror=return-type -Werror=return-mismatch], [CXXFLAGS])
+    AX_APPEND_COMPILE_FLAGS([-Werror=missing-field-initializers -Werror=format -Werror=return-mismatch], [CXXFLAGS])
     AC_LANG_POP(C++)
 ])
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/239eafa8b1a9a8f3e9d830232e09fba4675d705a

-- 
This project does not include diff previews in email notifications.
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/239eafa8b1a9a8f3e9d830232e09fba4675d705a
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance