[vlc-commits] [Git][videolan/vlc][master] 3 commits: package/win32: don't discard all unused args in UWP

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
1539eac3 by Steve Lhomme at 2024-11-07T10:51:09+00:00
package/win32: don't discard all unused args in UWP

Only ignore the options we add locally.
This is how it's done in the llvm-mingw wrappers.

- - - - -
619dff36 by Steve Lhomme at 2024-11-07T10:51:09+00:00
package/win32: pass -lwindowsapp with -Wl in VLC_LDFLAGS

Only used in UWP builds.

- - - - -
112d5c78 by Steve Lhomme at 2024-11-07T10:51:09+00:00
package/win32: don't issue a wanring when -gcodeview is not used

This may trigger some compiler detection in some contribs.
The warning is issued when linking through the compiler.

- - - - -


1 changed file:

- extras/package/win32/build.sh


Changes:

=====================================
extras/package/win32/build.sh
=====================================
@@ -287,12 +287,18 @@ if [ ! -z "$BUILD_UCRT" ]; then
             fi
         fi
 
-        VLC_LDFLAGS="$VLC_LDFLAGS -lwindowsapp"
+        if [ "$COMPILING_WITH_CLANG" -gt 0 ]; then
+            VLC_LDFLAGS="$VLC_LDFLAGS --start-no-unused-arguments"
+            VLC_CFLAGS="$VLC_CFLAGS --start-no-unused-arguments"
+            VLC_CXXFLAGS="$VLC_CXXFLAGS --start-no-unused-arguments"
+        fi
+        VLC_LDFLAGS="$VLC_LDFLAGS -Wl,-lwindowsapp"
         VLC_CFLAGS="$VLC_CFLAGS -Wl,-lwindowsapp"
         VLC_CXXFLAGS="$VLC_CXXFLAGS -Wl,-lwindowsapp"
         if [ "$COMPILING_WITH_CLANG" -gt 0 ]; then
-            VLC_CFLAGS="$VLC_CFLAGS -Wno-unused-command-line-argument"
-            VLC_CXXFLAGS="$VLC_CXXFLAGS -Wno-unused-command-line-argument"
+            VLC_LDFLAGS="$VLC_LDFLAGS --end-no-unused-arguments"
+            VLC_CFLAGS="$VLC_CFLAGS --end-no-unused-arguments"
+            VLC_CXXFLAGS="$VLC_CXXFLAGS --end-no-unused-arguments"
         fi
     else
         SHORTARCH="$SHORTARCH-ucrt"
@@ -339,8 +345,8 @@ echo $PATH
 mkdir -p contrib/contrib-$SHORTARCH && cd contrib/contrib-$SHORTARCH
 if [ ! -z "$WITH_PDB" ]; then
     CONTRIBFLAGS="$CONTRIBFLAGS --enable-pdb"
-    VLC_CFLAGS="$VLC_CFLAGS -gcodeview"
-    VLC_CXXFLAGS="$VLC_CXXFLAGS -gcodeview"
+    VLC_CFLAGS="$VLC_CFLAGS --start-no-unused-arguments -gcodeview --end-no-unused-arguments"
+    VLC_CXXFLAGS="$VLC_CXXFLAGS --start-no-unused-arguments -gcodeview --end-no-unused-arguments"
     if [ ! -z "$PDB_MAP" ]; then
         VLC_CFLAGS="$VLC_CFLAGS -fdebug-prefix-map='$VLC_ROOT_PATH'='$PDB_MAP'"
         VLC_CXXFLAGS="$VLC_CXXFLAGS -fdebug-prefix-map='$VLC_ROOT_PATH'='$PDB_MAP'"



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/5755ff89bc3b73d7e0847c362d47f82ab56fc5ff...112d5c78615a507373bc649f2fed432c91f717e4

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/5755ff89bc3b73d7e0847c362d47f82ab56fc5ff...112d5c78615a507373bc649f2fed432c91f717e4
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance