[vlc-commits] [Git][videolan/vlc][master] qt: polish qt widgets before setting transient parent

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
77706ff4 by Fatih Uzunoglu at 2024-11-17T09:54:08+00:00
qt: polish qt widgets before setting transient parent

See f6ce0828 for the reasoning. The same concern may
apply to different widgets, such as `QDialog` or
`QWizard`, that are actually windows.

- - - - -


2 changed files:

- modules/gui/qt/menus/menus.hpp
- modules/gui/qt/widgets/native/qvlcframe.cpp


Changes:

=====================================
modules/gui/qt/menus/menus.hpp
=====================================
@@ -41,7 +41,6 @@ public:
         assert(p_intf);
         if (isWindow())
         {
-            ensurePolished();
             QVLCDialog::setWindowTransientParent(this, nullptr, p_intf);
         }
     }


=====================================
modules/gui/qt/widgets/native/qvlcframe.cpp
=====================================
@@ -246,6 +246,7 @@ void QVLCDialog::setWindowTransientParent(QWidget* widget, QWindow* parent, qt_i
     if (!parent)
         return;
 
+    widget->ensurePolished();
     widget->createWinId();
     QWindow* handle  = widget->windowHandle();
     handle->setTransientParent(parent);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/77706ff45eade3709e9b2e69ba7608ed5628f964

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/77706ff45eade3709e9b2e69ba7608ed5628f964
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance