[vlc-commits] [Git][videolan/vlc][master] qml: do not override `dragStarted()` and `dragStopped()` signal of Flickable

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
96b74dc6 by Fatih Uzunoglu at 2024-11-19T05:12:19+00:00
qml: do not override `dragStarted()` and `dragStopped()` signal of Flickable

These signals seem to be added long time ago to Flickable but have not
been documented until recently, which explains why such names are used
here.

- - - - -


2 changed files:

- modules/gui/qt/dialogs/toolbar/qml/ToolbarEditor.qml
- modules/gui/qt/dialogs/toolbar/qml/ToolbarEditorButtonList.qml


Changes:

=====================================
modules/gui/qt/dialogs/toolbar/qml/ToolbarEditor.qml
=====================================
@@ -278,8 +278,8 @@ Item {
                     Layout.margins: VLCStyle.margin_xxsmall
 
                     Component.onCompleted: {
-                        dragStarted.connect(root.dragStarted)
-                        dragStopped.connect(root.dragStopped)
+                        controlDragStarted.connect(root.dragStarted)
+                        controlDragStopped.connect(root.dragStopped)
                     }
                 }
             }


=====================================
modules/gui/qt/dialogs/toolbar/qml/ToolbarEditorButtonList.qml
=====================================
@@ -44,8 +44,8 @@ GridView {
 
     property alias removeInfoRectVisible: removeInfoRect.visible
 
-    signal dragStarted(int id)
-    signal dragStopped(int id)
+    signal controlDragStarted(int id)
+    signal controlDragStopped(int id)
 
 
     readonly property ColorContext colorContext: ColorContext {
@@ -142,7 +142,7 @@ GridView {
 
         drag.onActiveChanged: {
             if (drag.active) {
-                dragStarted(mIndex)
+                root.controlDragStarted(mIndex)
 
                 buttonDragItem.text = PlayerControlbarControls.controlList[model.index].label
                 buttonDragItem.Drag.source = this
@@ -152,7 +152,7 @@ GridView {
             } else {
                 buttonDragItem.Drag.drop()
 
-                dragStopped(mIndex)
+                root.controlDragStopped(mIndex)
 
                 GridView.delayRemove = false
             }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/96b74dc60449c5766c05ebb573cae4df61b545ca

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/96b74dc60449c5766c05ebb573cae4df61b545ca
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance