[vlc-commits] [Git][videolan/vlc][master] deinterlace: remove unnecessary -O2 forcing for yadif

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
99c6d056 by Steve Lhomme at 2024-11-22T15:17:40+00:00
deinterlace: remove unnecessary -O2 forcing for yadif

Tested with -O0 with LLVM-mingw for win64 and win32.
It builds fine and uses the assembler code properly.

- - - - -


2 changed files:

- modules/video_filter/Makefile.am
- modules/video_filter/meson.build


Changes:

=====================================
modules/video_filter/Makefile.am
=====================================
@@ -172,8 +172,6 @@ libdeinterlace_plugin_la_CPPFLAGS = $(AM_CPPFLAGS)
 libdeinterlace_plugin_la_CFLAGS = $(AM_CFLAGS)
 if HAVE_X86ASM
 libdeinterlace_plugin_la_SOURCES += video_filter/deinterlace/yadif_x86.asm
-# inline ASM doesn't build with -O0
-libdeinterlace_plugin_la_CFLAGS += -O2
 endif
 if HAVE_ALTIVEC
 libdeinterlace_plugin_la_CPPFLAGS += -DCAN_COMPILE_C_ALTIVEC


=====================================
modules/video_filter/meson.build
=====================================
@@ -300,16 +300,12 @@ deinterlace_sources = files(
         'deinterlace/algo_phosphor.c',
         'deinterlace/algo_ivtc.c',
     )
-deinterlace_cargs=[]
 if cdata.has('HAVE_X86ASM')
     deinterlace_sources+=files('deinterlace/yadif_x86.asm')
-    # inline ASM doesn't build with -O0
-    deinterlace_cargs+=['-O2']
 endif
 vlc_modules += {
     'name' : 'deinterlace',
     'sources' : deinterlace_sources,
-    'c_args' : deinterlace_cargs,
     'include_directories' : include_directories('../../extras/include/x86'),
     'link_with' : [deinterlacecommon_lib]
 }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/99c6d056e32c3f347ed8c04baf1e8fb0a0346a68

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/99c6d056e32c3f347ed8c04baf1e8fb0a0346a68
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance