[vlc-commits] [Git][videolan/vlc][master] macosx: Remove subviews from home view stack view when deallocating the home...

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
13c44ed4 by Claudio Cambra at 2024-11-23T14:56:12+00:00
macosx: Remove subviews from home view stack view when deallocating the home view stack view controller

Turns out when switching views and deallocating the home view stack view
controller we were not emptying out the subviews for the actual stack
view, which had a reference held on it by the library window.

This means the created containers would stay alive and included in the
home view stack view's subviews... Then when switching back to the home
view we'd initialise a new home view stack view controller, which would
initialise new containers, and then add them to the home view stack
view, creating duplicates

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


1 changed file:

- modules/gui/macosx/library/home-library/VLCLibraryHomeViewStackViewController.m


Changes:

=====================================
modules/gui/macosx/library/home-library/VLCLibraryHomeViewStackViewController.m
=====================================
@@ -62,6 +62,11 @@
     return self;
 }
 
+- (void)dealloc
+{
+    self.collectionsStackView.subviews = @[];
+}
+
 - (void)setup
 {
     NSNotificationCenter * const notificationCenter = NSNotificationCenter.defaultCenter;



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/13c44ed411eccfbb0386cedf01f3e0f75d346cd9

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/13c44ed411eccfbb0386cedf01f3e0f75d346cd9
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance