[vlc-commits] [Git][videolan/vlc][master] qml: try to show tool tip after its position is adjusted

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
c189ba65 by Fatih Uzunoglu at 2024-11-30T17:40:21+00:00
qml: try to show tool tip after its position is adjusted

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/ToolTipExt.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/ToolTipExt.qml
=====================================
@@ -44,6 +44,23 @@ T.ToolTip {
             control.popupType = 1 // Popup.Window
     }
 
+    // NOTE: The tool tip often moves around, particularly noticable
+    //       with the attached (global) tool tip, and pointing tool
+    //       tip. Ideally, we could override property `visible` and
+    //       call `QQuickPopup::open()` with `Qt.callLater()`, but
+    //       the property is marked as FINAL. At the same time,
+    //       Qt disables the timer when the delay is 0, ideally we
+    //       need a timer with 0 delay, but 1 millisecond should
+    //       not be a big deal.
+    // NOTE: Mispositioned tool tip upon being visible is observed
+    //       especially with the independent window (`Popup.Window`)
+    //       setting. We need to make sure that its position is
+    //       adjusted before the tool tip is shown. For that reason,
+    //       be careful to not use complex bindings for the position
+    //       and text, as they may not be resolved as soon as the
+    //       tool tip is shown (single event loop cycle).
+    delay: 1
+
     readonly property ColorContext colorContext: ColorContext {
         id: theme
         colorSet: ColorContext.Tooltip



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/c189ba65e7b771c56b7e847480e7b434c3deca6b

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/c189ba65e7b771c56b7e847480e7b434c3deca6b
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance