[vlc-commits] [Git][videolan/vlc][master] macosx: Fix crash upon dealloc of VLCLibraryWindow

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
d22daeb7 by Claudio Cambra at 2024-10-09T16:25:30+00:00
macosx: Fix crash upon dealloc of VLCLibraryWindow

Caused by trying to remove KVO when none was added

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


1 changed file:

- modules/gui/macosx/library/VLCLibraryWindow.m


Changes:

=====================================
modules/gui/macosx/library/VLCLibraryWindow.m
=====================================
@@ -194,10 +194,6 @@ static void addShadow(NSImageView *__unsafe_unretained imageView)
 - (void)dealloc
 {
     [NSNotificationCenter.defaultCenter removeObserver:self];
-    if (@available(macOS 10.14, *)) {
-        [NSApplication.sharedApplication removeObserver:self forKeyPath:@"effectiveAppearance"];
-    }
-
     libvlc_int_t *libvlc = vlc_object_instance(getIntf());
     var_DelCallback(libvlc, "intf-toggle-fscontrol", ShowFullscreenController, (__bridge void *)self);
     var_DelCallback(libvlc, "intf-show", ShowController, (__bridge void *)self);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/d22daeb752416c56a8168d69fe243057677126d2

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/d22daeb752416c56a8168d69fe243057677126d2
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance