[vlc-commits] [Git][videolan/vlc][master] qml: fix flickering in pip player with Qt 6.7

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
66b6fb39 by Fatih Uzunoglu at 2024-10-12T13:06:54+00:00
qml: fix flickering in pip player with Qt 6.7

- - - - -


1 changed file:

- modules/gui/qt/player/qml/PIPPlayer.qml


Changes:

=====================================
modules/gui/qt/player/qml/PIPPlayer.qml
=====================================
@@ -98,9 +98,20 @@ T.Control {
 
     contentItem: Rectangle {
         color: "#10000000"
-        visible: hoverHandler.hovered
+        visible: hoverHandler.hovered ||
+                 playButton.hovered ||
+                 closeButton.hovered ||
+                 fullscreenButton.hovered
+
+        // Raise the content item so that the handlers of the control do
+        // not handle events that are to be handled by the handlers/items
+        // of the content item. Raising the content item should be fine
+        // because content item is supposed to be the foreground item.
+        z: 1
 
         Widgets.IconButton {
+            id: playButton
+
             anchors.centerIn: parent
 
             font.pixelSize: VLCStyle.icon_large
@@ -111,12 +122,12 @@ T.Control {
                   ? VLCIcons.pause_filled
                   : VLCIcons.play_filled
 
-            hoverEnabled: MainCtx.qtQuickControlRejectsHoverEvents()
-
             onClicked: MainPlaylistController.togglePlayPause()
         }
 
         Widgets.IconButton {
+            id: closeButton
+
             anchors {
                 top: parent.top
                 topMargin: VLCStyle.margin_small
@@ -128,12 +139,12 @@ T.Control {
             description: qsTr("close video")
             text: VLCIcons.close
 
-            hoverEnabled: MainCtx.qtQuickControlRejectsHoverEvents()
-
             onClicked: MainPlaylistController.stop()
         }
 
         Widgets.IconButton {
+            id: fullscreenButton
+
             anchors {
                 top: parent.top
                 topMargin: VLCStyle.margin_small
@@ -146,8 +157,6 @@ T.Control {
             description: qsTr("maximize player")
             text: VLCIcons.fullscreen
 
-            hoverEnabled: MainCtx.qtQuickControlRejectsHoverEvents()
-
             onClicked: MainCtx.requestShowPlayerView()
         }
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/66b6fb39708d02c117af3fd0ef89c2e61d650a13

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/66b6fb39708d02c117af3fd0ef89c2e61d650a13
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance